Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bundle/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
2 changes: 1 addition & 1 deletion .github/actions/commenter/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
2 changes: 1 addition & 1 deletion .github/actions/coverage-report/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
40 changes: 17 additions & 23 deletions .github/workflows/node-pr-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
name: Build and Test
defaults:
run:
working-directory: ui
steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: Use Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
- name: Install Dependencies
run: npm ci
- name: Build
Expand All @@ -31,50 +31,44 @@ jobs:
id: coverage
if: ${{ always() }}
uses: ./.github/actions/coverage-report
- name: Comment on PR
if: ${{ always() }}
uses: ./.github/actions/commenter
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BUNDLE_SIZE: ${{ steps.bundle.outputs.bundle_size }}
TEST_COVERAGE: ${{ steps.coverage.outputs.test_coverage }}

lint:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
name: ESLint
defaults:
run:
working-directory: ui

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: Use Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
- name: Install Dependencies
run: npm ci
- name: Code lint
run: npm run lint

e2e-tests:
runs-on: ubuntu-latest # or macos-latest, windows-latest
runs-on: ubuntu-22.04 # or macos-latest, windows-latest
defaults:
run:
working-directory: ui
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Increase file watcher limit
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 12.x
- uses: microsoft/playwright-github-action@v1
node-version: 16.x
- name: Install dependencies
run: npm ci
- name: set up playwright environment
run: npx playwright install
- name: run tests
run: npm run test:e2e
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: failures
Expand Down
5 changes: 3 additions & 2 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# MAINTAINERS

Kate Stanley - [email protected]
Grace Jansen - [email protected]
Aswin A - [email protected]
Graeme McRobert - [email protected]
Neeraj Laad - [email protected]
5 changes: 4 additions & 1 deletion ui/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
"sourceType": "module",
"ecmaFeatures": {
"jsx": true
},
"babelOptions": {
"presets": ["@babel/preset-env", "@babel/preset-react"]
}
},
"env": {
Expand All @@ -28,7 +31,7 @@
},
"import/resolver": "webpack"
},
"parser": "babel-eslint",
"parser": "@babel/eslint-parser",
"rules": {
"prettier/prettier": "error",
"strict": [2, "global"],
Expand Down
1 change: 1 addition & 0 deletions ui/e2e/features/step_definitions/producer.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const stepDefs = (cucumber) => {
'I set the payload to {string}',
async (world, payload) => {
await page.fill(getSelector('producer_value_input'), payload);
await page.waitForTimeout(150);
await page.waitForSelector(getSelector('producer_value_input'));
}
);
Expand Down
Loading
Loading