Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polars): support version 1.0 and later #9516

Merged
merged 12 commits into from
Jul 13, 2024
Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 4, 2024

Support Polars 1.0 and set lower bound to 1.0. There are many behavioral changes in Polars 1.0, such that it makes it difficult to justify supporting so many older versions. I say we cut losses and jump to 1.0 as the lower bound.

@cpcloud cpcloud added this to the 9.2 milestone Jul 4, 2024
@cpcloud cpcloud added feature Features or general enhancements polars The polars backend labels Jul 4, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Jul 4, 2024

Core dump reported upstream in pola-rs/polars#17425.

@chloeh13q
Copy link
Contributor

p.s. probably want to update the conda env files too - they're not upper bounded right now and I was running into problems when I updated my environment, but since this is going in soon (I think?) maybe we can just directly bump it to 1.+ there too instead of having an intermediary change?

@cpcloud
Copy link
Member Author

cpcloud commented Jul 12, 2024

@chloeh13q Yep, thanks!

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud merged commit 62a1864 into ibis-project:main Jul 13, 2024
77 checks passed
@cpcloud cpcloud deleted the polars-1 branch July 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements polars The polars backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants