Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix nix builds, relock files, remove setup.py #4598

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 30, 2022

This PR fixes failing master nix builds and also remove setup.py and related code. As of [email protected], editable installs (pip install -e .) are supported.

@cpcloud cpcloud added ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development labels Sep 30, 2022
@cpcloud cpcloud added this to the 4.0.0 milestone Sep 30, 2022
@cpcloud cpcloud requested a review from kszucs September 30, 2022 12:23
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

`poetry-core` >= 1.0.8 supporst PEP660 (editable installs)
`nixos-unstable-small` seems to have broken a few core python packages
@github-actions
Copy link
Contributor

Test Results

       6 files         6 suites   3m 51s ⏱️
3 210 tests 3 196 ✔️ 14 💤 0
9 603 runs  9 561 ✔️ 42 💤 0

Results for commit d1ec18e.

@cpcloud cpcloud enabled auto-merge (rebase) September 30, 2022 12:57
@cpcloud cpcloud merged commit eb82a26 into ibis-project:master Sep 30, 2022
@cpcloud cpcloud deleted the fix-nix branch September 30, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants