Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose APIs for constructing SortExprs using asc/desc functions and methods #1454

Closed
cpcloud opened this issue May 22, 2018 · 1 comment · Fixed by #3589
Closed

feat: expose APIs for constructing SortExprs using asc/desc functions and methods #1454

cpcloud opened this issue May 22, 2018 · 1 comment · Fixed by #3589
Labels
expressions Issues or PRs related to the expression API feature Features or general enhancements onboarding Issues that can be addressed by someone less familiar with ibis

Comments

@cpcloud
Copy link
Member

cpcloud commented May 22, 2018

This will enable sort expr specifications without having to pass an ascending argument or have a function like to_sort_expr which makes assumptions about the meaning of its second argument.

Moreover, it becomes a lot less cumbersome to specify multiple sort exprs in a function like array_agg that, in some backends supports an ORDER BY clause.
@cpcloud cpcloud added the expressions Issues or PRs related to the expression API label May 22, 2018
@cpcloud cpcloud added this to the 0.14 milestone May 22, 2018
@cpcloud cpcloud self-assigned this May 22, 2018
@cpcloud cpcloud modified the milestones: 0.14, 0.15 Jul 16, 2018
@cpcloud cpcloud modified the milestones: 1.0.0, Next Release Mar 13, 2019
@cpcloud cpcloud modified the milestones: Next Major Release, Next Feature Release Mar 26, 2019
@cpcloud cpcloud modified the milestones: 1.1.0, Next Feature Release May 19, 2019
@cpcloud cpcloud modified the milestones: 1.2.0, Next Feature Release Jun 24, 2019
@datapythonista datapythonista removed this from the Next Feature Release milestone Nov 13, 2020
@cpcloud cpcloud removed their assignment Dec 16, 2021
@cpcloud cpcloud added feature Features or general enhancements onboarding Issues that can be addressed by someone less familiar with ibis labels Dec 16, 2021
@cpcloud cpcloud changed the title Expose APIs for constructing SortExprs using asc/desc functions and methods feat: expose APIs for constructing SortExprs using asc/desc functions and methods Dec 16, 2021
@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2021

I think we just need an asc function/method to round out desc.

@hussainsultan hussainsultan mentioned this issue Mar 11, 2022
Merged
hussainsultan added a commit to hussainsultan/ibis that referenced this issue Mar 11, 2022
@hussainsultan
feat(api): add ibis.asc expression
cc6cfd4 
Fixes ibis-project#1454
cpcloud pushed a commit that referenced this issue Mar 11, 2022
@hussainsultan @cpcloud
feat(api): add ibis.asc expression
efe177e 
Fixes #1454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expressions Issues or PRs related to the expression API feature Features or general enhancements onboarding Issues that can be addressed by someone less familiar with ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Add ibis.asc expression hussainsultan/ibis
2 participants
@cpcloud @datapythonista