Skip to content

Conversation

@ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 24, 2025

🎫 Issue IBX-8552

Related PRs:

Description:

SonarCloud analysis is false positive and relates to change from $this->assert to self::assert

For QA:

This fix nothing out of the box in existing instalations - if wrong group is assigned (and it was by default), nothing we can do to fix it. However, this fix new instalations and adds possible configuration with remote content id so we avoid those problems in the future.

Documentation:

@ViniTou ViniTou requested a review from konradoboza March 25, 2025 08:15
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please deprecate old setting and remove in 5.0 ?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@pawlakadrian pawlakadrian self-requested a review April 3, 2025 13:04
Copy link

@pawlakadrian pawlakadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on DXP Commerce 4.6.x-dev

@ViniTou ViniTou merged commit b19a5dc into 4.6 Apr 3, 2025
15 checks passed
@ViniTou ViniTou deleted the ibx-8552-registration-group-remote-id branch April 3, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants