IBX-9727: Added missing strict types and adapted the codebase to PHP 8.3 #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
barw4
commented
Jul 16, 2025
| foreach ($valueDefinitions as $identifier => $valueDefinition) { | ||
| $this->valueDefinitions[$identifier] = $valueDefinition; | ||
| } | ||
| $this->groupedDefinitions[CustomGroup::CUSTOM_GROUP_IDENTIFIER] = $valueDefinitions; |
There was a problem hiding this comment.
I'm not sure about this one, $fieldDefinitions is an array of ValueDefinitionInterface, but groupedDefinitions requires array of ValueDefinitionGroupInterface, maybe someone has an idea why do we need it here
There was a problem hiding this comment.
Seems like it's not needed, groups are properly resolved via compiler pass
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
Regression run: ibexa/commerce#1404 |
adamwojs
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: