IBX-10170: Introduced AccessCheckController contract #111
Conversation
ezrobot
requested review from
Steveb-p,
adamwojs,
alongosz,
barw4,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
| public static function getSubscribedEvents(): array | ||
| { | ||
| return [ | ||
| ControllerArgumentsEvent::class => 'onControllerArgumentsEvent', |
There was a problem hiding this comment.
Isn't kernel.controller event more appropriate?
This event is dispatched after the controller has been resolved but before executing it. It's useful to initialize things later needed by the controller...
kernel.controller_arguments has a different purpose.
This event is dispatched just before a controller is called. It's useful to configure the arguments that are going to be passed to the controller.
There was a problem hiding this comment.
Not sure, it could be to early and arguments for controller are still not set. @adamwojs , did you tried mentioned one?
There was a problem hiding this comment.
I checked this out, and it seems that everything is working properly wirh kernel.controller.
| public function onControllerArgumentsEvent(ControllerArgumentsEvent $event): void | ||
| { | ||
| $controller = $event->getController(); | ||
| if (is_array($controller) && $controller[0] instanceof AccessCheckController) { |
There was a problem hiding this comment.
I'm pretty sure this can also be an invoke'able object (with __invoke method). While we ourselves never use controllers like that, there is nothing stoping someone else from doing so - since it's in Contracts namespace.
There was a problem hiding this comment.
I was just moving this from admin-ui, but you are right - fixed.
Also, string callables with static methods are also possible so I tried to handle those as well.
ViniTou
force-pushed
the
ibx-10170-access-check
branch
from
f42b5e7 to
5b9f72d
Compare
ViniTou
force-pushed
the
ibx-10170-access-check
branch
from
5b9f72d to
0daae07
Compare
|
|
QA Approved on Ibexa DXP Commerce 4.6-dev. |
6 participants
Description:
For QA:
Documentation: