-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8535: Dropped deprecated code #131
Conversation
3198c62
to
96336da
Compare
a331326
to
2c80110
Compare
338cdf3
to
620da67
Compare
620da67
to
52f7084
Compare
parameters: | ||
|
||
# Errors | ||
|
||
# Section | ||
|
||
# URLWildcard | ||
|
||
# URLAlias | ||
|
||
# Content | ||
|
||
# User group | ||
|
||
# User | ||
|
||
# ContentType | ||
|
||
# Object state | ||
|
||
# View | ||
|
||
# Trash | ||
|
||
# Location | ||
|
||
# Roles | ||
|
||
# Relation | ||
|
||
# Field Definition | ||
|
||
# Content type Group | ||
|
||
# HTTP | ||
|
||
# Cache | ||
|
||
# Services | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that more of "Table of Contents", so you can see what is where? I have no idea why someone did it this way instead of splitting it into separate configurations but that was the purpose afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this have totally no value under empty parameters
section, even more when you see that Services
are last.
Services have their own titles when given section starts. from my pov this is totally useless and just clutters config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not useless, but it is stupid beyond your imagination... you copy header name and look for other occurrences in file to jump to section you need. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is so inconsistent - there are #Roles
and #Role
, #Content type Group
is not even there, it more like looks that there were some parameters before - maybe those .class
ones which where used before rebranding and thats whats left after we dropped them.
This reverts commit db7dd88.
5eea4f9
to
4b5daf4
Compare
|
Description:
For QA:
Documentation: