Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8535: Dropped deprecated code #131

Merged
merged 17 commits into from
Oct 7, 2024
Merged

IBX-8535: Dropped deprecated code #131

merged 17 commits into from
Oct 7, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Aug 30, 2024

🎫 Issue IBX-8535

Description:

For QA:

Documentation:

@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from a331326 to 2c80110 Compare September 3, 2024 08:10
@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from 338cdf3 to 620da67 Compare September 9, 2024 05:43
@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from 620da67 to 52f7084 Compare September 18, 2024 14:15
@ViniTou ViniTou requested a review from a team September 30, 2024 10:56
@konradoboza konradoboza requested a review from a team September 30, 2024 11:01
Comment on lines -1 to -40
parameters:

# Errors

# Section

# URLWildcard

# URLAlias

# Content

# User group

# User

# ContentType

# Object state

# View

# Trash

# Location

# Roles

# Relation

# Field Definition

# Content type Group

# HTTP

# Cache

# Services

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that more of "Table of Contents", so you can see what is where? I have no idea why someone did it this way instead of splitting it into separate configurations but that was the purpose afaik.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this have totally no value under empty parameters section, even more when you see that Services are last.
Services have their own titles when given section starts. from my pov this is totally useless and just clutters config file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not useless, but it is stupid beyond your imagination... you copy header name and look for other occurrences in file to jump to section you need. :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is so inconsistent - there are #Roles and #Role, #Content type Group is not even there, it more like looks that there were some parameters before - maybe those .class ones which where used before rebranding and thats whats left after we dropped them.

@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from 5eea4f9 to 4b5daf4 Compare October 7, 2024 06:40
Copy link

sonarqubecloud bot commented Oct 7, 2024

@ViniTou ViniTou merged commit eb879e0 into main Oct 7, 2024
9 checks passed
@ViniTou ViniTou deleted the ibx-8535-deprecations branch October 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants