IBX-8175: OpenAPI compatible move user group endpoint

src/bundle/Resources/config/input_parsers.yml

@@ -882,3 +882,11 @@ services:
             $validator: '@validator'
         tags:
             - { name: ibexa.rest.input.parser, mediaType: application/vnd.ibexa.api.RestoreTrashItemInput }
+
+    Ibexa\Rest\Server\Input\Parser\MoveUserGroupInput:
+        parent: Ibexa\Rest\Server\Common\Parser
+        arguments:
+            $locationService: '@ibexa.api.service.location'
+            $validator: '@validator'
+        tags:
+            - { name: ibexa.rest.input.parser, mediaType: application/vnd.ibexa.api.MoveUserGroupInput }

src/bundle/Resources/config/routing.yml

@@ -1008,6 +1008,15 @@ ibexa.rest.delete_policy:
 
 # Users
 
+ibexa.rest.user_group.move:
+    path: /user/groups/{groupPath}
+    controller: Ibexa\Rest\Server\Controller\User::moveGroup
+    condition: 'ibexa_get_media_type(request) === "MoveUserGroupInput"'
+    methods: [POST]
+    options:
+        options_route_suffix: 'MoveUserGroupInput'
+    requirements:
+        groupPath: "[0-9/]+"
 
 ibexa.rest.verify_users:
     path: /user/users

src/lib/Server/Controller/User.php

@@ -631,6 +631,46 @@ public function moveUserGroup(string $groupPath, Request $request): Values\Resou
         );
     }
 
+    /**
+     * @throws \Ibexa\Contracts\Rest\Exceptions\NotFoundException
+     * @throws \Ibexa\Core\Base\Exceptions\UnauthorizedException
+     */
+    public function moveGroup(string $groupPath, Request $request): Values\ResourceCreated
+    {
+        $userGroupLocation = $this->locationService->loadLocation(
+            $this->extractLocationIdFromPath($groupPath)
+        );
+
+        $userGroup = $this->userService->loadUserGroup(
+            $userGroupLocation->contentId,
+        );
+
+        /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Location $destinationLocation */
+        $destinationLocation = $this->inputDispatcher->parse(
+            new Message(
+                ['Content-Type' => $request->headers->get('Content-Type')],
+                $request->getContent(),
+            ),
+        );
+
+        $destinationGroup = $this->userService->loadUserGroup(
+            $destinationLocation->getContent()->getId(),
+        );
+
+        $this->userService->moveUserGroup($userGroup, $destinationGroup);
+
+        return new Values\ResourceCreated(
+            $this->router->generate(
+                'ibexa.rest.load_user_group',
+                [
+                    'groupPath' => trim($destinationLocation->pathString, '/')
+                        . '/'
+                        . $userGroupLocation->getId(),
+                ],
+            )
+        );
+    }
+
     /**
      * Returns a list of the sub groups.
      */

src/lib/Server/Input/Parser/MoveUserGroupInput.php

@@ -0,0 +1,22 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace Ibexa\Rest\Server\Input\Parser;
+
+use Ibexa\Rest\Server\Validation\Builder\Input\Parser\BaseInputParserValidatorBuilder;
+use Ibexa\Rest\Server\Validation\Builder\Input\Parser\MoveUserGroupInputValidatorBuilder;
+
+final class MoveUserGroupInput extends AbstractDestinationLocationParser
+{
+    protected const string PARSER = 'MoveUserGroupInput';
+
+    protected function getValidatorBuilder(): BaseInputParserValidatorBuilder
+    {
+        return new MoveUserGroupInputValidatorBuilder($this->validator);
+    }
+}

src/lib/Server/Validation/Builder/Input/Parser/MoveUserGroupInputValidatorBuilder.php

@@ -0,0 +1,29 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace Ibexa\Rest\Server\Validation\Builder\Input\Parser;
+
+use Ibexa\Rest\Server\Input\Parser\MoveUserGroupInput;
+use Symfony\Component\Validator\Constraint;
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class MoveUserGroupInputValidatorBuilder extends BaseInputParserValidatorBuilder
+{
+    protected function buildConstraint(): Constraint
+    {
+        return new Assert\Collection(
+            [
+                MoveUserGroupInput::DESTINATION_KEY => [
+                    new Assert\NotBlank(),
+                    new Assert\Type('string'),
+                    new Assert\Regex('/^(\/\d+)+$/'),
+                ],
+            ],
+        );
+    }
+}

tests/bundle/Functional/HttpOptionsTest.php

@@ -123,6 +123,7 @@ public function providerForTestHttpOptions(): array
             ['/user/groups/root', ['GET']],
             ['/user/groups/subgroups', ['POST']],
             ['/user/groups/4', ['GET', 'PATCH', 'DELETE', 'MOVE']],
+            ['/user/groups/4', ['POST'], 'MoveUserGroupInput+json'],
             ['/user/groups/4/subgroups', ['GET', 'POST']],
             ['/user/groups/4/users', ['GET', 'POST']],
             ['/user/groups/4/roles', ['GET', 'POST']],

tests/bundle/Functional/UserTest.php

@@ -9,6 +9,7 @@
 namespace Ibexa\Tests\Bundle\Rest\Functional;
 
 use Ibexa\Tests\Bundle\Rest\Functional\TestCase as RESTFunctionalTestCase;
+use Psr\Http\Message\ResponseInterface;
 
 final class UserTest extends RESTFunctionalTestCase
 {
@@ -379,7 +380,7 @@ public function testUnassignUserFromUserGroup(string $userHref): void
      *
      * @depends testCreateUserGroup
      */
-    public function testMoveUserGroup(string $groupHref): void
+    public function testMoveUserGroup(string $groupHref): ResponseInterface
     {
         $request = $this->createHttpRequest(
             'MOVE',
@@ -392,6 +393,32 @@ public function testMoveUserGroup(string $groupHref): void
         $response = $this->sendHttpRequest($request);
 
         self::assertHttpResponseCodeEquals($response, 201);
+
+        return $response;
+    }
+
+    /**
+     * @depends testMoveUserGroup
+     */
+    public function testMoveGroup(ResponseInterface $response): void
+    {
+        $userGroupHref = $response->getHeader('Location')[0];
+
+        $request = $this->createHttpRequest(
+            'POST',
+            $userGroupHref,
+            'MoveUserGroupInput+json',
+            '',
+            json_encode(
+                ['MoveUserGroupInput' => ['destination' => '/1/5']],
+                JSON_THROW_ON_ERROR,
+            ),
+        );
+
+        $response = $this->sendHttpRequest($request);
+
+        self::assertHttpResponseCodeEquals($response, 201);
+        self::assertHttpResponseHasHeader($response, 'Location');
     }
 
     /**

tests/lib/Server/Input/Parser/MoveUserGroupInputTest.php

@@ -0,0 +1,45 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace Ibexa\Tests\Rest\Server\Input\Parser;
+
+use Ibexa\Contracts\Core\Repository\LocationService;
+use Ibexa\Rest\Server\Input\Parser\MoveUserGroupInput;
+use Symfony\Component\Validator\Validation;
+
+final class MoveUserGroupInputTest extends AbstractDestinationLocationInputTest
+{
+    private const string PARSER = 'MoveUserGroupInput';
+
+    public function testParse(): void
+    {
+        $this->parse();
+    }
+
+    public function testParseExceptionOnMissingDestinationElement(): void
+    {
+        $this->parseExceptionOnMissingDestinationElement(self::PARSER);
+    }
+
+    public function testParseExceptionOnInvalidDestinationElement(): void
+    {
+        $this->parseExceptionOnInvalidDestinationElement(self::PARSER);
+    }
+
+    protected function internalGetParser(): MoveUserGroupInput
+    {
+        $locationService = $this->createMock(LocationService::class);
+        $this->locationService = $locationService;
+        $this->validator = Validation::createValidator();
+
+        return new MoveUserGroupInput(
+            $this->locationService,
+            $this->validator,
+        );
+    }
+}