IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
2 times, most recently
from
c703e9b to
1b96d0c
Compare
This was referenced Oct 18, 2024
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
10 times, most recently
from
acf0af3 to
12fc955
Compare
albozek
approved these changes
Oct 23, 2024
GrabowskiM
requested changes
Oct 25, 2024
| "@svgr/webpack": "^8.1.0" | ||
| "@svgr/webpack": "^8.1.0", | ||
| "ts-loader": "^9.5.1", | ||
| "ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa" |
There was a problem hiding this comment.
we should install this package using specific tag (which currently doesn't exist probably), to avoid problems with updating config in the future.
This comment is valid for all other places as well, of course. :)
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
4 times, most recently
from
7623ba9 to
66bde2b
Compare
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
from
bae2995 to
60f5a28
Compare
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
2 times, most recently
from
071c6b3 to
eb2b49a
Compare
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
from
eb2b49a to
cf0b682
Compare
albozek
approved these changes
Nov 20, 2024
GrabowskiM
requested changes
Nov 20, 2024
dew326
reviewed
Nov 20, 2024
tischsoic
approved these changes
Nov 20, 2024
OstafinL
force-pushed
the
IBX-9109-enabling-typescript
branch
from
260a44a to
20922a8
Compare
GrabowskiM
approved these changes
Nov 22, 2024
dew326
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: