IBX-9942: Updated deployment process to use Symfony Cloud configurator and symfony-deploy #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
adamwojs
reviewed
May 21, 2025
| if ($productPackage === null) { | ||
| throw new RuntimeException(sprintf('Could not find product "%s" in installed versions.', $product)); | ||
| } | ||
|
|
There was a problem hiding this comment.
What is the reason behind this change ?
There was a problem hiding this comment.
https://github.com/composer/composer/blob/main/src/Composer/InstalledVersions.php#L269
Due to this, when script called InstalledVersions::getRawData()['versions'][$product] I got 'no such key in array' error
adamwojs
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/oss#218
Description:
Updated deployment process to use Symfony Cloud configurator and symfony-deploy