[BC BREAK] IBX-7946: Renamed main SA aware config node from notifications to notifier #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6Related PRs:
When implementing this package I overlooked the fact
notificationsnode is already defined in Admin UI. We have name collision here and in result you can't override notification settings from Admin UI.I was considering different solutions and opted for the simplest one - just rename the node and avoid doing hacky things to keep old configuration working in both
ibexa/admin-uiandibexa/notifications. It's a BC break but no other solution I've come up with was 100% BC safe and it always ended up being a maintenance mess.ibexa/notificationsadoption is still very low as it's early in 4.6 life cycle and the package was never properly documented since it's not widely used in Ibexa DXP yet.How to deal with introduced BC break
If you are already using this package (
ibexa/notifications) and used SiteAccess aware configuration to change Notification subscriptions your configuration will no longer work and it'll fail early in container compilation process. You have to manually change your configuration by using new node namenotifierinstead of the old onenotifications.becomes:
Documentation:
Document the BC break for 4.6.3 release as described above.