-
Notifications
You must be signed in to change notification settings - Fork 4
IBX-10312: Rebranded VCL #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@adriendupuis Could you please finalize this PR ? |
@adamwojs Sorry for the delay. I decided to abandon few things to finalize this PR. |
Rename backend to correspond to ibexa/http-cache#64
87cdd16 to
0c29e37
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, but given this is all "glued together", I'd like to see here some manual QA and confirmation it works on P.sh.
Regression tests should be enough in case of this PR. |
Rename backend to correspond to ibexa/http-cache#64



Related PRs:
Description:
Rename headerFor BC, it's probably better to keepvnd.ezplatform.invalidate-tokenavailable as an alternative to a newvnd.ibexa.invalidate-token. I won't do it in this PR.Rename tagFor BC, it's probably better to not renameez-all, just to addibexa-allalongside as a start. I won't do it in this PR.About CI, I made this temporary change to use ibexa/docker#42 branch: 76e9398
And I get all green:
For QA:
Documentation: