Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9251: Run browser tests on different Ubuntu versions #54

Closed
wants to merge 13 commits into from

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Nov 26, 2024

🎫 Issue IBX-9251

Description:

Run on Ubuntu 24.04, 22.04 and 20.04. Chosen randomly for given setup - each job in a setup gets the same OS version.

Ref. https://doc.ibexa.co/en/latest/getting_started/requirements/#operating-system

Pros of approach:

  • no extra jobs are introduced (no impact on API limits)

Cons:

  • in case of failed jobs and restarts, different Ubuntu edition might be chosen (could increase diagnosis time, if fail was edition related)

For QA:

Q: Can runners in a group be used? (initial idea)
A: Runner groups are meant to be used with self-hosted runners only, not for Github-hosted ones.

Open question: Since Docker is used for different versions of services, what exactly is the impact of different Ubuntu editions?

Summary:

Result of restarting a job:

  • single "browser tests" job - Ubuntu version is kept
  • "setup jobs" job (triggers restart of all "browser tests" jobs in that setup) - Ubuntu version is not kept
  • "Re-run all jobs" button - Ubuntu versions are not kept

Using artifacts with a file holding chosen Ubuntu version is not sufficient. Artifacts are not shared between workflow runs which turned out includes restarts.
A possible solution could be to combine artifacts with an external cloud storage. Sounds like overengineering.

The cost in complexity to join increased coverage with good reliability without affecting API limits is too high. If at all possible for all scenarios. For now reliability of tests is key. Topic can be revisited if new GHA mechanisms surface.

@micszo micszo changed the title IBX-9251: Run on Ubuntu 24.04 IBX-9251: Run browser tests on different Ubuntu versions Dec 18, 2024
@micszo micszo marked this pull request as ready for review December 18, 2024 13:04
@micszo micszo requested review from a team and juskora January 8, 2025 11:23
@tomaszszopinski
Copy link

Is there any way to force a certain ubuntu version after a restart/fail ? I fear that here we trade increased coverage for decreased reliability (and im not really a fan of that :( ).

@micszo micszo force-pushed the ibx-9251 branch 4 times, most recently from 247bab2 to af8ab41 Compare January 23, 2025 16:07
@micszo
Copy link
Contributor Author

micszo commented Jan 24, 2025

Added summary in description.

@micszo micszo closed this Jan 24, 2025
@micszo micszo deleted the ibx-9251 branch January 24, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants