IBX-10262: Renamed and refactored CustomTagsValidator to support both Custom Tags and Styles
#253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th Custom Tags and Styles
ezrobot
requested review from
Steveb-p,
ViniTou,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
wiewiurdp
and removed request for
a team
adamwojs
reviewed
Jul 10, 2025
…d `CustomTagsValidator` alias
|
|
It works. 
|
adamwojs
reviewed
Jul 10, 2025
| * The Validator checks if the given XML reflects proper Custom Tags configuration, | ||
| * mostly existence of specific Custom Tag and its required attributes. | ||
| */ | ||
| class CustomTagsValidator implements ValidatorInterface |
There was a problem hiding this comment.
Please make sure this change is documented. This is BC break.
There was a problem hiding this comment.
@mnocon requires your attention 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR renames and refactors the existing CustomTagsValidator class to CustomTemplateValidator, expanding its responsibility to validate both: