Skip to content

Conversation

@GrabowskiM
Copy link
Contributor

🎫 Issue IBX-10087

Description:

For QA:

Documentation:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses IBX-10087 by ensuring that left-aligned images no longer overlap adjacent blocks in Richtext fields.

  • Introduces a clearfix rule for elements directly following an element with the data-ezalign attribute.
Comments suppressed due to low confidence (1)

src/bundle/Resources/public/scss/_general.scss:175

  • Consider adding a comment to explain the purpose of using the adjacent sibling combinator here, which will help future maintainers understand how this rule addresses the overlapping issue.
[data-ezalign] + * {

@sonarqubecloud
Copy link

@GrabowskiM GrabowskiM changed the base branch from main to 4.6 June 12, 2025 08:24
Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrabowskiM It looks fine now, but could we also fix the bug ? Where, when inserting a YouTube widget right after an image, the widget management panel doesn’t appear. I have to press Enter (go to a new line) first, and only then it shows up. The issue is shown in the video.

Nagranie.z.ekranu.2025-06-20.o.12.55.26.mov

@KamilSznajdrowicz
Copy link

KamilSznajdrowicz commented Jul 4, 2025

@GrabowskiM It looks fine now, but could we also fix the bug ? Where, when inserting a YouTube widget right after an image, the widget management panel doesn’t appear. I have to press Enter (go to a new line) first, and only then it shows up. The issue is shown in the video.

Nagranie.z.ekranu.2025-06-20.o.12.55.26.mov

After discussions, reported here:https://issues.ibexa.co/browse/IBX-10270

Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved

@dew326 dew326 merged commit 12090a8 into 4.6 Jul 4, 2025
22 of 23 checks passed
@dew326 dew326 deleted the IBX-10087 branch July 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants