IBX-10066: Change lint config to 2.0 #234
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s linting and CI configuration to align with version 2.0.
- Introduces a top‐level
eslint.config.mjsthat spreads in the new Ibexa ESLint rules. - Refines the GitHub Actions workflow to trigger only on relevant front‐end file changes and bumps Node.js from v18 to v20.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eslint.config.mjs | Adds default Ibexa ESLint configuration via getIbexaConfig() |
| .github/workflows/frontend-ci.yaml | Restricts workflows to JS/TS/SCSS paths and updates Node.js to v20 |
Files not reviewed (4)
- .eslintrc.json: Language not supported
- ibexa.tsconfig.json: Language not supported
- package.json: Language not supported
- tsconfig.eslint.json: Language not supported
.github/workflows/frontend-ci.yaml
Outdated
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" |
There was a problem hiding this comment.
The glob pattern ".[cm]?[jt]sx?" will not reliably match your JS/TS files. Consider using a brace expansion like "/*.{js,jsx,ts,tsx,cjs,mjs}" to cover all extensions.
| - "**.scss" | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" |
There was a problem hiding this comment.
The pattern ".scss" won’t match SCSS files in subdirectories. Use "/*.scss" to include all .scss files recursively.
.github/workflows/frontend-ci.yaml
Outdated
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" |
There was a problem hiding this comment.
Same as above: update this pull_request trigger to use "**/*.{js,jsx,ts,tsx,cjs,mjs}" to ensure JS/TS changes are captured.
| - "**.[cm]?[jt]sx?" | |
| - "**/*.{js,jsx,ts,tsx,cjs,mjs}" |
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" |
There was a problem hiding this comment.
Same as above: change to "**/*.scss" under pull_request so SCSS files in subfolders trigger the workflow.
| - "**.scss" | |
| - "**/*.scss" |
|
4 participants
Description:
For QA:
Documentation: