Skip to content

Conversation

@alongosz
Copy link
Member

@alongosz alongosz commented Mar 3, 2025

Caution

Merge together with other IBX-8471 Pull Requests

  • Make sure TMP commit(s) are dropped before merging
🎫 Issue IBX-8471

Description:

Upgrading Symfony dependencies to version 7 along with necessary 3rd party packages and codebase changes.
For this package, the most notable changes are related to major upgrade of doctrine/dbal package to v3.

SQLSessionInit event subscriber got deprecated in favor of EnableForeignKeys middleware. Therefore the new contract has been introduced - \Ibexa\DoctrineSchema\Database\DbPlatform\DbPlatformInterface::configure which can configure an instance of \Doctrine\DBAL\Configuration, by e.g. calling $configuration->setMiddlewares([new EnableForeignKeys()] for SQLite.

Key changes:

  • [Composer] Bumped Symfony packages requirements to ^7.2
  • [Composer] Bumped 3rd party packages compatible with for Symfony 7
  • [Rector] Applied DoctrineSetList rector sets for DBAL v3
  • [Tests][Rector] Applied DoctrineSetList rector sets for DBAL v3
  • Dropped support for deprecated implementations of AbstractPlatform
  • Upgraded codebase to Doctrine DBAL v3
  • [Tests] Upgraded tests to Doctrine DBAL v3
  • Improved package's codebase quality
  • [Tests] Improved package's tests quality
  • [Rector] Updated set list after Symfony 7 upgrade
  • Added DbPlatformInterface::configure contract
  • [Tests] Fixed SqliteDbPlatformTest after adding configure contract

For QA:

Sanity tests and/or regression builds.

@alongosz alongosz force-pushed the ibx-8471-symfony-7 branch from 68c8b6f to 0dac402 Compare March 25, 2025 12:54
@alongosz alongosz marked this pull request as ready for review March 25, 2025 12:57
@alongosz alongosz requested a review from a team March 25, 2025 12:57
@konradoboza konradoboza requested a review from a team March 25, 2025 13:33
@alongosz alongosz requested a review from Steveb-p March 25, 2025 13:50
@alongosz alongosz force-pushed the ibx-8471-symfony-7 branch from f0cf162 to 561209c Compare May 7, 2025 10:24
@alongosz
Copy link
Member Author

alongosz commented May 7, 2025

Update: added \Ibexa\DoctrineSchema\Database\DbPlatform\DbPlatformInterface::configure contract that can be utilized by ibexa/core for SQLite-based tests which require foreign keys. Knowing what needs to be configured is a responsibility of an implementation of the abstract platform.

@alongosz alongosz requested review from a team and adamwojs May 7, 2025 10:30
@ViniTou ViniTou force-pushed the ibx-8471-symfony-7 branch from 561209c to 059d904 Compare May 12, 2025 06:55
@sonarqubecloud
Copy link

@adamwojs adamwojs merged commit 6081624 into main May 12, 2025
6 of 10 checks passed
@adamwojs adamwojs deleted the ibx-8471-symfony-7 branch May 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants