Skip to content

IBX-10507: Allowed nullable type declarations for method parameters across the codebase #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

IBX-10507: Allowed nullable type declarations for method parameters across the codebase #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c7c425
Allowed nullable type declarations for method parameters across the c…
Sep 8, 2025
3d39cad
Allowed nullable type declarations for method parameters across the c…
Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bundle/DataCollector/TwigDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\DataCollector\LateDataCollectorInterface;
use Throwable;
use Twig\Environment;
use Twig\Profiler\Profile;

Expand All @@ -36,7 +37,7 @@ private function getTemplatePathRegistry()
return $this->templatePathRegistry;
}

public function collect(Request $request, Response $response, \Throwable $exception = null)
public function collect(Request $request, Response $response, ?Throwable $exception = null)
{
parent::collect($request, $response, $exception);
}
Expand Down
4 changes: 2 additions & 2 deletions src/lib/Asset/AssetPathResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ class AssetPathResolver implements AssetPathResolverInterface
private $webRootDir;

/**
* @var \Psr\Log\LoggerInterface
* @var \Psr\Log\LoggerInterface|null
*/
private $logger;

public function __construct(array $designPaths, $webRootDir, LoggerInterface $logger = null)
public function __construct(array $designPaths, $webRootDir, ?LoggerInterface $logger = null)
{
$this->designPaths = $designPaths;
$this->webRootDir = $webRootDir;
Expand Down
Loading