IBX-10341: Fixed accessing templatePathRegistry property in TwigDataCollector::getTemplatePathRegistry #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollector::getTemplatePathRegistry https://issues.ibexa.co/browse/IBX-10341
|
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
barw4
approved these changes
Jul 21, 2025
konradoboza
approved these changes
Jul 21, 2025
alongosz
approved these changes
Jul 21, 2025
adamwojs
approved these changes
Jul 21, 2025
Steveb-p
reviewed
Jul 21, 2025
| private function getTemplatePathRegistry(): TemplatePathRegistryInterface | ||
| { | ||
| return $this->templatePathRegistry; | ||
| return $this->templatePathRegistry ??= unserialize($this->data['template_path_registry']); |
There was a problem hiding this comment.
Is serializing and unserializing services a common pattern in Symfony Data Collectors?
Steveb-p
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
I understand that this is the current state of code, but really serialization should not be used for Data Collector purposes.
Every data collector I checked was extracting only the data it was capable of displaying in the profiler. Serialization of a whole service instance will bloat the profiler record, especially if registry is decorated.
tomaszszopinski
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes bug - accessing property before initialization introduced in #38
For QA:
Documentation: