Skip to content

[CI] Fixed newly reported phpstan errors #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

[CI] Fixed newly reported phpstan errors #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc68cc
[CI] Fixed newly reported phpstan errors
ViniTou Jul 22, 2025
bf209f3
Added errors to baseline as there are fixed on php8+
ViniTou Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions phpstan-baseline-7.4.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,18 @@ parameters:
count: 3
path: tests/integration/Core/Repository/RoleServiceTest.php

-
message: '#^Parameter \#1 \$class of class ReflectionProperty constructor expects object\|string, class\-string\|false given\.$#'
identifier: argument.type
count: 4
path: tests/integration/Core/Repository/SearchServiceLocationTest.php

-
message: '#^Parameter \#1 \$class of class ReflectionProperty constructor expects object\|string, class\-string\|false given\.$#'
identifier: argument.type
count: 4
path: tests/integration/Core/Repository/SearchServiceTest.php

-
message: '#^Parameter \#1 \$str of function md5 expects string, int\<1, max\> given\.$#'
identifier: argument.type
Expand Down
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,6 @@ parameters:
count: 1
path: src/bundle/Core/Command/ReindexCommand.php

-
message: '#^Parameter \#2 \$subject of function preg_match expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: src/bundle/Core/Command/ReindexCommand.php

-
message: '#^Parameter \#2 \$subject of function preg_match_all expects string, string\|false given\.$#'
identifier: argument.type
Expand Down
2 changes: 1 addition & 1 deletion src/lib/FieldType/MapLocation/MapLocationStorage/Gateway/DoctrineStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function getFieldData(VersionInfo $versionInfo, Field $field)
* @param int $fieldId
* @param int $versionNo
*
* @return array|null
* @return array|\ArrayAccess<string, float>|null
*/
protected function loadFieldData($fieldId, $versionNo)
{
Expand Down
6 changes: 5 additions & 1 deletion src/lib/Repository/Helper/RelationProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ public function processFieldRelations(
if ($relationType === Relation::FIELD || $relationType === Relation::ASSET) {
foreach ($relationData as $fieldDefinitionId => $contentIds) {
foreach (array_keys($contentIds) as $destinationContentId) {
if (isset($mappedRelations[$relationType][$fieldDefinitionId][$destinationContentId])) {
if (
isset($mappedRelations[$relationType][$fieldDefinitionId]) &&
is_array($mappedRelations[$relationType][$fieldDefinitionId]) &&
isset($mappedRelations[$relationType][$fieldDefinitionId][$destinationContentId])
) {
unset($mappedRelations[$relationType][$fieldDefinitionId][$destinationContentId]);
} else {
$this->persistenceHandler->contentHandler()->addRelation(
Expand Down
3 changes: 2 additions & 1 deletion tests/lib/Validation/ValidationFailedExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ public function testEmptyErrorList(): void
'Cannot create %s with empty validation error list.',
ValidationFailedException::class,
));
new ValidationFailedException('__argument_name__', $errors);
$exception = new ValidationFailedException('__argument_name__', $errors);
self::assertSame($errors, $exception->getErrors());
}
}
Loading