IBX-10253: Fixed condition checks for sending a file with BinaryStreamResponse #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Jul 10, 2025
konradoboza
approved these changes
Jul 10, 2025
Co-authored-by: Konrad Oboza <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR fixes my mistake during Symfony 6 upgrade code refactoring (#447). Looks like
maxlenproperty is actually equal to -1 when not using Ranges request (default behavior).I've added very minimal test coverage, as it seems this was detected only now by manual tests...
Additionally, I've added strict getters to BinaryFile value object, since it required little effort and didn't obfuscate diff too much.
For QA:
I recommend standard QA for this bug (steps as described in JIRA).