IBX-10137: Moved slug transformation rules to production Resources

.sonarcloud.properties

@@ -1 +1 @@
-sonar.exclusions=tests/**/_fixtures/**/*
+sonar.exclusions=tests/**/_fixtures/**/*,src/lib/Resources/slug_converter/transformations/*

phpstan-baseline.neon

@@ -52212,12 +52212,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/Legacy/Content/LanguageAwareTestCase.php
 
-		-
-			message: '#^Parameter \#3 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/LanguageAwareTestCase.php
-
 		-
 			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\LanguageAwareTestCase\:\:\$fieldNameGeneratorMock \(Ibexa\\Core\\Search\\Common\\FieldNameGenerator&PHPUnit\\Framework\\MockObject\\MockObject\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -54924,162 +54918,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabaseTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:cleanupTextData\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:convertData\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:getSlugConverterMock\(\) has parameter \$methods with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:getSlugConverterMock\(\) should return Ibexa\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverter&PHPUnit\\Framework\\MockObject\\MockObject but returns PHPUnit\\Framework\\MockObject\\MockObject\.$#'
-			identifier: return.type
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:providerForTestGetUniqueCounterValue\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testCleanupText\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testCleanupText\(\) has parameter \$expected with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testCleanupText\(\) has parameter \$method with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testCleanupText\(\) has parameter \$text with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvert\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertNoMocking\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertNoMocking\(\) has parameter \$defaultText with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertNoMocking\(\) has parameter \$expected with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertNoMocking\(\) has parameter \$text with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertNoMocking\(\) has parameter \$transformation with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertWithDefaultTextFallback\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testConvertWithGivenTransformation\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testGetUniqueCounterValue\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testGetUniqueCounterValue\(\) has parameter \$isRootLevel with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testGetUniqueCounterValue\(\) has parameter \$returnValue with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:testGetUniqueCounterValue\(\) has parameter \$text with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Parameter \#1 \$transformationProcessor of class Ibexa\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverter constructor expects Ibexa\\Core\\Persistence\\TransformationProcessor, PHPUnit\\Framework\\MockObject\\MockObject given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:\$configuration type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:\$slugConverter \(Ibexa\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverter\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:\$slugConverterMock \(PHPUnit\\Framework\\MockObject\\MockObject\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
-		-
-			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\SlugConverterTest\:\:\$transformationProcessorMock \(PHPUnit\\Framework\\MockObject\\MockObject\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/SlugConverterTest.php
-
 		-
 			message: '#^Argument of an invalid type Ibexa\\Contracts\\Core\\Persistence\\Content\\UrlAlias supplied for foreach, only iterables are supported\.$#'
 			identifier: foreach.nonIterable
@@ -56094,12 +55932,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/Legacy/Content/UrlAlias/UrlAliasHandlerTest.php
 
-		-
-			message: '#^Parameter \#3 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Persistence/Legacy/Content/UrlAlias/UrlAliasHandlerTest.php
-
 		-
 			message: '#^Property Ibexa\\Tests\\Core\\Persistence\\Legacy\\Content\\UrlAlias\\UrlAliasHandlerTest\:\:\$languageHandler \(Ibexa\\Core\\Persistence\\Legacy\\Content\\Language\\Handler\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -57270,18 +57102,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/Limitation/Target/Builder/VersionBuilderTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\TransformationProcessor\\TransformationProcessorDefinitionBasedParserTest\:\:testParse\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorDefinitionBasedParserTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\TransformationProcessor\\TransformationProcessorDefinitionBasedParserTest\:\:testParse\(\) has parameter \$file with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorDefinitionBasedParserTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Core\\Persistence\\TransformationProcessor\\TransformationProcessorDefinitionBasedTest\:\:getProcessor\(\) has no return type specified\.$#'
 			identifier: missingType.return
@@ -57312,12 +57132,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorDefinitionBasedTest.php
 
-		-
-			message: '#^Parameter \#3 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorDefinitionBasedTest.php
-
 		-
 			message: '#^Class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased\\Parser constructor invoked with 1 parameter, 0 required\.$#'
 			identifier: arguments.count
@@ -57426,12 +57240,6 @@ parameters:
 			count: 1
 			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorPreprocessedBasedTest.php
 
-		-
-			message: '#^Parameter \#2 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\PreprocessedBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Persistence/TransformationProcessor/TransformationProcessorPreprocessedBasedTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Core\\QueryType\\BuiltIn\\AbstractQueryTypeTestCase\:\:dataProviderForGetQuery\(\) return type has no value type specified in iterable type iterable\.$#'
 			identifier: missingType.iterableValue
@@ -64584,12 +64392,6 @@ parameters:
 			count: 1
 			path: tests/lib/Search/Legacy/Content/HandlerContentTest.php
 
-		-
-			message: '#^Parameter \#3 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Search/Legacy/Content/HandlerContentTest.php
-
 		-
 			message: '#^Class Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Query\\SortClause\\Field constructor invoked with 4 parameters, 2\-3 required\.$#'
 			identifier: arguments.count
@@ -65160,12 +64962,6 @@ parameters:
 			count: 1
 			path: tests/lib/Search/Legacy/Content/HandlerLocationTest.php
 
-		-
-			message: '#^Parameter \#3 \$ruleFiles of class Ibexa\\Core\\Persistence\\TransformationProcessor\\DefinitionBased constructor expects array, list\<string\>\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/lib/Search/Legacy/Content/HandlerLocationTest.php
-
 		-
 			message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertInstanceOf\(\) with ''Ibexa\\\\Contracts\\\\Core\\\\Specification\\\\Content\\\\ContentSpecification'' and Ibexa\\Contracts\\Core\\Specification\\Content\\ContentContainerSpecification will always evaluate to true\.$#'
 			identifier: staticMethod.alreadyNarrowedType

src/lib/Resources/settings/storage_engines/common.yml

@@ -3,24 +3,24 @@ parameters:
 
     # Transformation rules resources
     ibexa.api.storage_engine.transformation_rules.resources:
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/ascii.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/basic.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/cyrillic.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/greek.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/hebrew.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/latin.tr"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/search.tr"
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/ascii.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/basic.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/cyrillic.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/greek.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/hebrew.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/latin.tr'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/search.tr'
 
     # Using preprocessed files:
 
     ibexa.api.storage_engine.preprocessed_transformation_rules.resources:
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/ascii.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/basic.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/cyrillic.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/greek.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/hebrew.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/latin.tr.result"
-        - "%ibexa.kernel.root_dir%/tests/lib/Persistence/TransformationProcessor/_fixtures/transformations/search.tr.result"
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/ascii.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/basic.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/cyrillic.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/greek.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/hebrew.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/latin.tr.result.php'
+        - '%ibexa.kernel.root_dir%/src/lib/Resources/slug_converter/transformations/search.tr.result.php'
 
 services:
     Ibexa\Core\Persistence\FieldTypeRegistry: