Skip to content

Conversation

@adamwojs
Copy link
Member

🎫 Issue IBX-9727

Description:

  • Narrowed down return type from iterable to array in \Ibexa\Contracts\Core\Repository\UserService::{deleteUser, deleteUserGroup} methods
  • Narrowed down return type from iterable to array in Ibexa\Contracts\Core\Repository\ContentService::deleteContent method
  • Add missing type hints to PAPI event structs

For QA:

N/A

Documentation:

N/A

@sonarqubecloud
Copy link

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for iterable -> array change

+1 for the other changes based on diff with my previous work on branch ibx-8471-symfony-7-full - though that's technically +1 to my own code ;)

@adamwojs adamwojs merged commit 132c789 into main May 30, 2025
15 checks passed
@adamwojs adamwojs deleted the add_missing_type_hints_to_papi_events branch May 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants