Skip to content

Conversation

@alongosz
Copy link
Member

🎫 Issue IBX-9941

Related PRs:

Description:

I finally managed to finish the review of #541 (better late than never, right? ;-))

I found some minor things, mostly nitpicks, that can be improved:

  • [Tests] Renamed ezbinaryfile.yaml to ibexa_binary_file.yaml
  • [Tests] Fixed @covers value for Bookmark GW DoctrineDatabaseTest
  • [Tests] Optimized Bookmark GW DoctrineDatabaseTest::loadBookmark::loadBookmark query (columns instead of * - µ-optimization ofc, but was looking at the file anyway)
  • [Tests] Fixed @covers value for Content GW DoctrineDatabaseTest
  • [Tests] Fixed Notification GW DoctrineDatabaseTest after Doctrine update - contained deprecated Doctrine syntax
  • Unwrapped unnecessary curly braces when referencing table name variables - it seems we rather tend to not use those if I remember correctly? // modified for the affected scope only

For QA:

No QA required.

@alongosz alongosz force-pushed the ibx-9941-post-merge-improvements branch from d0e2e20 to cc986d7 Compare May 29, 2025 12:22
@alongosz alongosz force-pushed the ibx-9941-post-merge-improvements branch from cc986d7 to b38e649 Compare May 29, 2025 21:40
@sonarqubecloud
Copy link

@alongosz alongosz requested a review from a team May 30, 2025 08:26
@ezrobot ezrobot requested review from Steveb-p, ViniTou, adamwojs, barw4, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team May 30, 2025 08:26
@adamwojs adamwojs merged commit 2983b31 into main May 30, 2025
25 checks passed
@adamwojs adamwojs deleted the ibx-9941-post-merge-improvements branch May 30, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants