Skip to content

Conversation

@tbialcz
Copy link
Contributor

@tbialcz tbialcz commented May 22, 2025

🎫 Issue IBX-8226

Related PRs:

Description:

This PR removes the \Ibexa\Contracts\Core\MVC\Symfony\ErrorHandler\Php82HideDeprecationsErrorHandler class, which was used to suppress PHP 8.2 deprecations. As of PHP 8.3, the handler is no longer necessary and has been fully removed from the codebase.

  • Removal of Php82HideDeprecationsErrorHandler class
  • Cleanup of any references to the handler

@sonarqubecloud
Copy link

Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CI fail related? It seems at first glance, but the report is pretty vague.

@tbialcz
Copy link
Contributor Author

tbialcz commented May 22, 2025

Is CI fail related? It seems at first glance, but the report is pretty vague.

Yes, the CI failure is related to this issue. It occurred because the Composer configuration still had the old error_handler set to the removed Php82HideDeprecationsErrorHandler class. After removing that setting from the CI scripts, the error should no longer occur, and the build should pass successfully.

Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, already approved the related PR so +1 here as well.

@adamwojs
Copy link
Member

I've merge related PR. Let's see if browsers test will pass now.

@adamwojs adamwojs merged commit 1af6f9d into main May 22, 2025
28 checks passed
@adamwojs adamwojs deleted the ibx_8226 branch May 22, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants