-
Notifications
You must be signed in to change notification settings - Fork 17
[BC break] Added implements \Stringable to Translation Value Object
#344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3394277 to
af6c78b
Compare
Steveb-p
approved these changes
Mar 1, 2024
|
konradoboza
approved these changes
Mar 1, 2024
|
Can we implement |
ViniTou
approved these changes
Mar 7, 2024
af6c78b to
2c79176
Compare
|
Translation::__toString implementationimplements \Stringable to Translation Value Object
Steveb-p
approved these changes
Apr 24, 2024
konradoboza
approved these changes
Apr 25, 2024
webhdx
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Description:
\Ibexa\Contracts\Core\Repository\Values\Translationclass has no__toString()method but all two implementations:Plural, andMessage- have it. Given we operate on the common abstract contract, it causes static analysis issue:This method should be declared on the
Translationabstract. The easiest way to solve it is to implement\Stringableon the abstract Translation class, forcing all its children to actually implementpublic function __toString(): string.For QA:
No QA required, regressions are enough.
Documentation:
Should be documented as a breaking change. I'll update proper internal document that will be used when documenting all 5.0 breaks, so for this PR no "doc needed" label.
Checklist:
$ composer fix-cs).