-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-5630: Added possibility to extend URL schema resolving #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It would be preferred to fix all CI issues before someone takes a look at it. Also short summary of changes is always helpful to make the review process more effective. |
998a5f6 to
31bce2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems to be good direction. Parts of the system need immediate improvements to avoid increasing technical debt which is already big for NameSchemaService.
Please also make sure that there's integration test coverage for name and url alias generation from schema (some test that checks that in ./tests/integration/Core). If it is and passes - that's good - no BC break. If there's no test like that, it needs to be added.
0938085 to
f597591
Compare
f597591 to
c25142e
Compare
838de1e to
6128c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ef69404 to
eadb0f3
Compare
aca4ddf to
96020b1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Congrats @kisztof 🎉 |








v4.5This PR adds an extension point for resolving URL schema.
New event added
ResolveUrlAliasSchemaEventChecklist:
$ composer fix-cs).@ibexa/engineering).