IBX-8470: Upgraded codebase to Symfony 6 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a part of bigger set of changes, to be merged together when ready
Related PRs:
Description:
This PR bumps Symfony to v6 and improves codebase. I've added strict types to consts and missing return type(s) and I've also fixed PHPStan-specific data types type-hints to include phpstan- prefix as those are not recognized by phpDocumentor and sometimes IDE.
Except for static analysis, it's hard to say if the code works because there's 0 test coverage here. Browser tests for now will fail, until all packages are upgraded.
Key changes:
QA:
Sanities in the form of regression tests.
Documentation:
No documentation required.