Applied automatic code upgrade #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
upgrade_code
branch
from
1a38aef to
cc0062a
Compare
|
konradoboza
reviewed
Feb 25, 2025
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Almost all remarks are about readonly, haven't continued. Please check it maybe with 8.3 syntax enabled within PHPStorm.
Comment on lines
+27
to
+29
| private ContentTypeService $contentTypeService, | ||
| private ContentService $contentService, | ||
| private ActionDispatcherInterface $contentActionDispatcher |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
Comment on lines
+34
to
+42
| private ContentTypeService $contentTypeService, | ||
| private UserService $userService, | ||
| private LocationService $locationService, | ||
| private LanguageService $languageService, | ||
| private ActionDispatcherInterface $userActionDispatcher, | ||
| private PermissionResolver $permissionResolver, | ||
| private UserLanguagePreferenceProviderInterface $userLanguagePreferenceProvider, | ||
| private GroupedContentFormFieldsProviderInterface $groupedContentFormFieldsProvider, | ||
| private ContentService $contentService |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
Comment on lines
+37
to
+38
| private PermissionResolver $permissionResolver, | ||
| private ContentTypeService $contentTypeService |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
| private $configResolver; | ||
|
|
||
| public function __construct(ConfigResolverInterface $configResolver) | ||
| public function __construct(private ConfigResolverInterface $configResolver) |
Contributor
There was a problem hiding this comment.
Suggested change
| public function __construct(private ConfigResolverInterface $configResolver) | |
| public function __construct(private readonly ConfigResolverInterface $configResolver) |
Comment on lines
+58
to
+61
| private PermissionResolver $permissionResolver, | ||
| private RoleService $roleService, | ||
| private UserService $userService, | ||
| private ContentTypeService $contentTypeService |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
Comment on lines
+29
to
+31
| private RouterInterface $router, | ||
| private URLAliasService $urlAliasService, | ||
| private LocationService $locationService |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
| UrlGeneratorInterface $urlGenerator | ||
| ) { | ||
| $this->urlGenerator = $urlGenerator; | ||
| public function __construct(private UrlGeneratorInterface $urlGenerator) |
Contributor
There was a problem hiding this comment.
Suggested change
| public function __construct(private UrlGeneratorInterface $urlGenerator) | |
| public function __construct(private readonly UrlGeneratorInterface $urlGenerator) |
Comment on lines
+30
to
+31
| private UserService $userService, | ||
| private UrlGeneratorInterface $urlGenerator |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
Comment on lines
+27
to
+29
| private UserService $userService, | ||
| private ContentService $contentService, | ||
| private UrlGeneratorInterface $urlGenerator |
Contributor
There was a problem hiding this comment.
Could those be readonly as well?
| private $fieldTypeFormMapper; | ||
|
|
||
| public function __construct(FieldTypeFormMapperDispatcherInterface $fieldTypeFormMapper) | ||
| public function __construct(private FieldTypeFormMapperDispatcherInterface $fieldTypeFormMapper) |
Contributor
There was a problem hiding this comment.
Suggested change
| public function __construct(private FieldTypeFormMapperDispatcherInterface $fieldTypeFormMapper) | |
| public function __construct(private readonly FieldTypeFormMapperDispatcherInterface $fieldTypeFormMapper) |
Member
Author
|
Closed in favor of #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following PR applies automatic code upgrade rule sets.
For QA:
Sanities.
Documentation:
N/A