Skip to content

Conversation

@ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Sep 22, 2025

🎫 Issue IBX-9917

Related PRs:

Description:

In my opinion reported phpstan issue (and its new, it wasnt there like two weeks ago) is false positive. There is nothing in

/**
 * @property \Ibexa\Contracts\ContentForms\Data\Content\FieldData[] $fieldsData
 * @property \Ibexa\Contracts\Core\Repository\Values\Content\Content $contentDraft
 */
class ContentUpdateData extends ContentUpdateStruct implements NewnessCheckable
{
    use ContentData;

    protected $contentDraft;

    public function isNew()
    {
        return false;
    }
}

that guarantess that $contentDraft is not null, unless I am not seeing something. That @property annotation is missleading as we seen in the past many times before when dealing with our VO.

For QA:

Documentation:

@ViniTou ViniTou force-pushed the ibx-9917-autosave-collaboration branch from c245b52 to c8d0a75 Compare September 22, 2025 13:53
@ViniTou ViniTou requested a review from a team September 22, 2025 13:55
@ezrobot ezrobot requested review from Steveb-p, adamwojs, alongosz, barw4, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team September 22, 2025 13:55
@sonarqubecloud
Copy link

@ViniTou ViniTou merged commit 9db0626 into 4.6 Oct 3, 2025
14 checks passed
@ViniTou ViniTou deleted the ibx-9917-autosave-collaboration branch October 3, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants