Added setup to disable Help Center as default #161
Conversation
ezrobot
requested review from
KamilSznajdrowicz,
barbaragr,
juskora,
katarzynazawada,
micszo and
tomaszszopinski
and removed request for
a team
|
Regression: |
behat_ibexa_commerce.yaml
Outdated
| - Ibexa\Discounts\Behat\Context\DiscountsInStorefrontContext | ||
| - Ibexa\DiscountsCodes\Behat\Context\DiscountsCodesInStorefrontContext | ||
| - Ibexa\ActivityLog\Behat\Context\ActivityLogContext | ||
| - Ibexa\ActivityLog\Behat\Context\ActivityLogContext |
There was a problem hiding this comment.
Please add new line here an the end of the file
There was a problem hiding this comment.
Sure, fixed all new line's
behat_suites.yml
Outdated
| - Ibexa\AdminUi\Behat\BrowserContext\UserPreferencesContext | ||
| - Ibexa\AdminUi\Behat\BrowserContext\NavigationContext | ||
| - Ibexa\Behat\Browser\Context\AuthenticationContext | ||
| - Ibexa\AdminUi\Behat\BrowserContext\ContentActionsMenuContext |
There was a problem hiding this comment.
As above - please add new line here an the end of the file
| And I'm on Content view Page for root | ||
| And I go to user settings | ||
| And I disable Help center | ||
| Then I perform the "Save and close" action No newline at end of file |
There was a problem hiding this comment.
As above - please add new line here an the end of the file
| And I disable Help center | ||
| Then I perform the "Save and close" action No newline at end of file |
There was a problem hiding this comment.
There’s a missing step to verify whether the click actually worked. Your last step is saving without any validation. If the button is clicked but nothing happens, your test will still pass as successful even though it’s not working properly.
| And I disable Help center | |
| Then I perform the "Save and close" action | |
| When I disable Help center | |
| And I perform the "Save and close" action | |
| Then Help center is disabled |
There was a problem hiding this comment.
Good catch! I added additional step for that one
|
5 participants
Related PRs:
ibexa/admin-ui#1739
Description:
This PR is to address regression issues caused by enabling the help center by default.
An additional setup is added to disable the help center in the user settings.
For QA:
Documentation: