Skip to content

[Behat] IBX-10592: Implemented basic behat coverage for notification feature #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 4.6
Choose a base branch
from
Open

[Behat] IBX-10592: Implemented basic behat coverage for notification feature #1746

wants to merge 4 commits into from

Conversation

@KamilSznajdrowicz
Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz commented Oct 16, 2025 •
edited
Loading

🎫 Issue IBX-10592

Related PRs:

Description:

This PR introduces automated behat tests covering the notification feature functionality in the admin interface.
Tests include:

  • Popup notifications: verify that notifications appear when content is sent to review, can be marked as read/unread, and deleted.
  • All Notifications view: verify that users can access all notifications, mark them as read/unread, navigate to related content, and delete notifications from the list.

For QA:

📗 Regression: ibexa/commerce#1551

Documentation:

@KamilSznajdrowicz KamilSznajdrowicz force-pushed the ibx-10592-cover-notifications-feature branch from 345ed66 to 7705326 Compare October 24, 2025 10:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

This was referenced Oct 27, 2025
Draft
Open
@KamilSznajdrowicz KamilSznajdrowicz requested a review from a team October 27, 2025 13:18
@ezrobot ezrobot requested review from barbaragr, juskora, katarzynazawada, micszo, pawlakadrian and tomaszszopinski and removed request for a team October 27, 2025 13:18
tomaszszopinski
tomaszszopinski approved these changes Oct 28, 2025
View reviewed changes
src/bundle/Resources/config/services/test/pages.yaml

Ibexa\AdminUi\Behat\Page\UserProfilePage: ~

Ibexa\AdminUi\Behat\Page\NotificationsPage: ~
Copy link
Contributor

@tomaszszopinski tomaszszopinski Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ibexa\AdminUi\Behat\Page\NotificationsPage: ~
Ibexa\AdminUi\Behat\Page\NotificationsViewAllPage: ~

NotificationsPage is too vague imo.

tomaszszopinski
tomaszszopinski requested changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missclicked earlier 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski requested changes

@micszo micszo Awaiting requested review from micszo

@pawlakadrian pawlakadrian Awaiting requested review from pawlakadrian

@barbaragr barbaragr Awaiting requested review from barbaragr

@katarzynazawada katarzynazawada Awaiting requested review from katarzynazawada

@juskora juskora Awaiting requested review from juskora

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@ViniTou ViniTou

Labels

Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KamilSznajdrowicz @tomaszszopinski @mikadamczyk @ciastektk @ViniTou