IBX-9855: Added isHidden property to ContentTree Node
#1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
barw4
reviewed
Aug 18, 2025
| public $isInvisible; | ||
|
|
||
| /** @var bool */ | ||
| public $isHidden; |
There was a problem hiding this comment.
Suggested change
| public $isHidden; | |
| public bool $isHidden; |
konradoboza
reviewed
Aug 18, 2025
Comment on lines
56
to
57
| $generator->startValueElement('isHidden', $generator->serializeBool($data->isHidden)); | ||
| $generator->endValueElement('isHidden'); |
There was a problem hiding this comment.
Use valueElement instead.
| '', // node name will be provided later by `supplyTranslatedContentName` method | ||
| null !== $contentType ? $contentType->getIdentifier() : '', | ||
| null === $contentType || $contentType->isContainer(), | ||
| $location->isInvisible() || $location->isHidden(), |
There was a problem hiding this comment.
Isn't that behavior change?
There was a problem hiding this comment.
Yes it is, It is needed for FE
https://issues.ibexa.co/browse/IBX-9855
https://github.com/ibexa/tree-builder/pull/186
adamwojs
approved these changes
Aug 18, 2025
konradoboza
approved these changes
Aug 18, 2025
barw4
approved these changes
Aug 18, 2025
mikadamczyk
approved these changes
Aug 19, 2025
tbialcz
approved these changes
Aug 19, 2025
pawlakadrian
force-pushed
the
IBX-9855-fixing-visibility-status
branch
from
36396ef to
a9f373a
Compare
|
pawlakadrian
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Added
isHiddenproperty to ContentTree Node