Skip to content

Added --watch option to ibexa:encore:compile #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2025
Merged

Added --watch option to ibexa:encore:compile #1671

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84aab74
CompileAssetsCommand.php: Add --watch
adriendupuis Aug 6, 2025
4af32c3
CompileAssetsCommand.php: Throw error on `--watch --timeout 123`
adriendupuis Aug 12, 2025
64ac790
CompileAssetsCommand.php: Fix help
adriendupuis Aug 12, 2025
a220c2d
CompileAssetsCommand.php: Set timeout back as a float for fromShellCo…
adriendupuis Aug 12, 2025
3ae897b
CompileAssetsCommand.php: Fix code style
adriendupuis Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/bundle/Command/CompileAssetsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,17 @@ public function __construct(int $timeout = self::COMMAND_DEFAULT_TIMEOUT)
protected function configure(): void
{
$this
->addOption(
'watch',
'w',
InputOption::VALUE_NONE,
'Watch mode rebuilds on file change'
)
->addOption(
'timeout',
't',
InputOption::VALUE_REQUIRED,
'Timeout in seconds',
'Timeout in seconds (ignored in watch mode)',
$this->timeout
)
->addOption(
Expand Down Expand Up @@ -77,7 +83,8 @@ protected function getFrontendConfigPath(string $configName): string

protected function execute(InputInterface $input, OutputInterface $output): int
{
$timeout = (float)$input->getOption('timeout');
$watch = $input->getOption('watch');
$timeout = $watch ? null : (float)$input->getOption('timeout');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone passes --timeout, but we silently discard it due to --watch, it should raise an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 84aab74...a220c2d I implemented the error when both options are used at the same time --watch --timeout 123.
To be able to detected if the user passed the --timeout option, I had to remove its default value from definition.

$env = $input->getOption('env');
$configName = $input->getOption('config-name');
$frontendConfigsName = $input->getOption('frontend-configs-name');
Expand All @@ -89,6 +96,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$yarnBaseEncoreCommand = "yarn encore {$encoreEnv}";
$yarnEncoreCommand = $yarnBaseEncoreCommand;

if ($watch) {
$yarnEncoreCommand = "{$yarnBaseEncoreCommand} --watch";
}

if (!empty($configName)) {
$yarnEncoreCommand = "{$yarnBaseEncoreCommand} --config-name {$configName}";
}
Expand Down
Loading