Skip to content

IBX-10398: Modal close btn styles update #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: 4.6
merged 2 commits into from
Aug 7, 2025
Merged

IBX-10398: Modal close btn styles update #1661

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57e224
IBX-10398: Modal close btn styles update
albozek Jul 31, 2025
2ceb5a8
after review
albozek Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/bundle/Resources/public/scss/_modals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

.close {
@include close-button();
padding: calculateRem(2px);
}
}

Expand Down
5 changes: 3 additions & 2 deletions src/bundle/Resources/views/themes/admin/ui/component/modal/modal.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,18 @@
{% set close_btn_title = 'close_btn.title'|trans({}, 'ibexa_modal')|desc('Close') %}
{% set close_btn_aria_label = 'close_btn.aria_label'|trans({}, 'ibexa_modal')|desc('Close') %}
{% set attr_close_btn = attr_close_btn|default({})|merge({
class: ('close ' ~ attr_close_btn.class|default(''))|trim,
class: ('close ibexa-btn ibexa-btn--ghost ' ~ attr_close_btn.class|default(''))|trim,
type: attr_close_btn.type|default('button'),
title: attr_close_btn.title|default(close_btn_title),
'data-bs-dismiss': attr_close_btn['data-bs-dismiss']|default('modal'),
'data-tooltip-container-selector': '.modal-dialog',
'aria-label': attr_close_btn['aria-label']|default(close_btn_aria_label),
}) %}

{% set close_btn %}
<button {{ html.attributes(attr_close_btn) }}>
<svg
class="ibexa-icon ibexa-icon--small-medium"
class="ibexa-icon ibexa-icon--medium"
aria-hidden="true"
>
<use xlink:href="{{ ibexa_icon_path('discard') }}"></use>
Expand Down
Loading