Skip to content

IBX-10168: Fixed missing assets icons #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

IBX-10168: Fixed missing assets icons #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bundle/DependencyInjection/Configuration/Parser/Assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ public function mapConfig(array &$scopeSettings, $currentScope, ContextualizerIn
}

foreach ($scopeSettings[self::ASSETS_NODE] as $identifier => $config) {
if (empty($config)) {
continue;
}

$contextualizer->setContextualParameter(sprintf('%s.%s', self::ASSETS_NODE, $identifier), $currentScope, $config);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/config/icons_aliases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
system:
admin_group:
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain reasoning behind this change ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case there were missing icons in customer portal, which isn't one of admin_group, therefore icon mapping was missing there.

There will be same problem with each site access that isn't part of admin_group that was using our icons through icon helper, so default will catch all of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per description of the issue in the linked ticket:

Missing icon for:

Embed block in PB
Several blocks in Dashboard builder (see screenshot)
Spilt/Unified option in version compare
Customer portal - Members list
Customer portal - Address book - Add
Customer portal -My profile - Edit - AI icon
Customer portal - Invite members modal

This means that there are several site accesses that are missing icon sets. Making those sets part of the default, paired with change that empty icon sets are not considered "valid" for the purposes of establishing a site-access parameter, alleviates the immediate issue.

I would like to open this discussion further into how we could deal with - basically - merging of different configuration levels, which is currently impossible. Site access level of icon sets overwrites site group access settings, which overwrite defaults (don't gonna even mention global...).

But that is a different story and broader in scope than resolving this issue.

assets:
icon_aliases:
about-info: help
Expand Down
Loading