IBX-10239: Fixed malfunctioning URL management pagination #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
approved these changes
Jul 2, 2025
Steveb-p
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
I don't think it's a good idea to remove the page and limit from the data object (having it there allows validation to be performed, should it be used 😅 ). But there is nothing stoping us from adding it back once there is some value in it.
(It doesn't mean form needs to have hidden fields. Data object does not need to correspond 1-to-1 to data object)
katarzynazawada
force-pushed
the
ibx-10239-fixed-pagination-on-url-management
branch
from
33dcc33 to
5faa690
Compare
|
katarzynazawada
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In short:
pageandlimitdon't need to be parts of the form as hidden inputs. We can rely on query params like in other tabs containing paginated results.I also took liberty to adjust related code to PHP8 a little.