IBX-10125: Handled image upload failed request #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
GrabowskiM,
Steveb-p,
ViniTou,
adamwojs,
alongosz,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
Steveb-p
approved these changes
Jun 25, 2025
| const getErrorMessageObject = (response) => { | ||
| const responseErrorMessage = response.json().then((jsonResponse) => { | ||
| return jsonResponse.ErrorMessage; | ||
| return jsonResponse.ErrorMessage ?? jsonResponse; |
There was a problem hiding this comment.
With HTTP error code other than 2XX, response.ok below will be false.
I would treat jsonResponse.ErrorMessage not being set as an error in this function, and throw an Error. Otherwise you return an object instead of string, and there is a high likelihood that follow up code will fail on that instead.
There was a problem hiding this comment.
@Steveb-p Actually, it seems that jsonResponse.ErrorMessage was meant to be an object, not a string. This is especially visible here:
jsonResponse
adamwojs
approved these changes
Jun 25, 2025
konradoboza
approved these changes
Jun 25, 2025
ViniTou
approved these changes
Jun 25, 2025
barw4
force-pushed
the
ibx-10125-handle-failed-requests
branch
from
c490353 to
37c00d8
Compare
KamilSznajdrowicz
force-pushed
the
ibx-10125-handle-failed-requests
branch
from
37c00d8 to
64f87ea
Compare
|
KamilSznajdrowicz
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Two things:
jsonResponse.ErrorMessagecall was giving empty results. Shouldn't we rather fallback to full response?For QA:
Documentation: