Skip to content

IBX-10170: Refactored access check to use new contract interface #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

IBX-10170: Refactored access check to use new contract interface #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c449418
IBX-10170: Refactored access check to use new contract interface
ViniTou Jun 18, 2025
b808510
Dropped service definition
ViniTou Jun 18, 2025
18b8e48
renamed to RestrictedControllerInterface
ViniTou Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions src/bundle/EventSubscriber/PerformAccessCheckSubscriber.php
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/bundle/Resources/config/services/events.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ services:
tags:
- { name: kernel.event_subscriber }

Ibexa\Bundle\AdminUi\EventSubscriber\PerformAccessCheckSubscriber:
tags:
- { name: kernel.event_subscriber }

Ibexa\AdminUi\EventListener\RequestListener:
arguments:
- '%ibexa.site_access.groups_by_site_access%'
Expand Down
9 changes: 4 additions & 5 deletions src/contracts/Controller/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@
namespace Ibexa\Contracts\AdminUi\Controller;

use Ibexa\Contracts\Core\Repository\Values\Content\Location;
use Ibexa\Contracts\User\Controller\AuthenticatedRememberedCheckTrait;
use Ibexa\Contracts\User\Controller\RestrictedControllerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\RedirectResponse;

abstract class Controller extends AbstractController
abstract class Controller extends AbstractController implements RestrictedControllerInterface
{
public function performAccessCheck(): void
{
$this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
}
use AuthenticatedRememberedCheckTrait;

public function redirectToLocation(Location $location, string $uriFragment = ''): RedirectResponse
{
Expand Down
Loading