IBX-10141: Add new icon names for IncludedIcon component #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
requested review from
OstafinL,
RopRaptor,
albozek,
Copilot,
dew326 and
tischsoic
There was a problem hiding this comment.
Pull Request Overview
This PR updates the icon mappings for the IncludedIcon component by replacing deprecated imports with a new set of icon names and updating the default icon values.
- Refactored icon imports and mappings
- Updated default parameter values for the component
- Introduced a new mapping group (bcIconsMap) to support additional icon names
Comments suppressed due to low confidence (1)
src/bundle/ui-dev/src/modules/common/icon/inculdedIcon.js:132
- The component and file name 'InculdedIcon' appears misspelled; consider renaming it to 'IncludedIcon' for improved clarity and consistency.
const InculdedIcon = ({ name = 'help', cssClass = '', defaultIconName = 'help' }) => {
OstafinL
approved these changes
Jun 9, 2025
RopRaptor
approved these changes
Jun 10, 2025
albozek
approved these changes
Jun 11, 2025
|
dew326
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: