- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
IBX-9060: Revamp notifications #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR revamps the notifications functionality and introduces new sidebar interactions while updating related configuration and routing. Key changes include:
- Introducing a new sidebar panel with improved event handling and backdrop management.
- Revamping notifications modal and list functionality by adding support for actions such as marking notifications as read/unread, bulk operations, and deletion.
- Updating routing, service configurations, and default settings to support the new notifications features.
Reviewed Changes
Copilot reviewed 27 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description | 
|---|---|
| src/bundle/Resources/public/js/scripts/sidebar/side.panel.js | New sidebar panel implementation with close triggers and backdrop control. | 
| src/bundle/Resources/public/js/scripts/admin.notifications.modal.js | Updates to notifications modal including new actions and improved event management. | 
| src/bundle/Resources/public/js/scripts/admin.notifications.list.js | Introduction of notifications list with bulk operations and status management. | 
| src/bundle/Resources/public/js/scripts/admin.notifications.filters.js | New filters implementation for notifications. | 
| src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js | Improvement in multilevel popup menu initialization with refactored event handling. | 
| src/bundle/Resources/encore/ibexa.js.config.js | Updated configuration to include new notifications list entry. | 
| src/bundle/Resources/config/services/controllers.yaml | Added new controller service definitions for notifications. | 
| src/bundle/Resources/config/routing.yaml | Introduced new routes to support notifications actions. | 
| src/bundle/Resources/config/ezplatform_default_settings.yaml | Increased pagination limit for notifications. | 
Files not reviewed (11)
- src/bundle/Controller/AllNotificationsController.php: Language not supported
- src/bundle/Controller/NotificationController.php: Language not supported
- src/bundle/Form/Data/SearchQueryData.php: Language not supported
- src/bundle/Form/Type/SearchType.php: Language not supported
- src/bundle/Resources/public/scss/_header-user-menu.scss: Language not supported
- src/bundle/Resources/public/scss/_list-filters.scss: Language not supported
- src/bundle/Resources/public/scss/_notifications-modal.scss: Language not supported
- src/bundle/Resources/public/scss/_notifications.scss: Language not supported
- src/bundle/Resources/public/scss/_side-panel.scss: Language not supported
- src/bundle/Resources/public/scss/ibexa.scss: Language not supported
- src/bundle/Resources/translations/ibexa_admin_ui.en.xliff: Language not supported
Comments suppressed due to low confidence (1)
src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js:2
- [nitpick] The function name 'initMutlilevelPopupMenus' appears to contain a typographical error; consider renaming it to 'initMultilevelPopupMenus' for clarity.
const initMutlilevelPopupMenus = (container) => {
        
          
                src/bundle/Resources/public/js/scripts/admin.notifications.list.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
      106b699    to
    46edda7      
    Compare
  
    485f3de    to
    d537c29      
    Compare
  
            
          
                src/bundle/Resources/public/js/scripts/admin.notifications.list.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/public/js/scripts/admin.notifications.filters.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/public/js/scripts/admin.notifications.filters.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/public/js/scripts/admin.notifications.list.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/views/themes/admin/account/notifications/side_panel.html.twig
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/views/themes/admin/ui/component/side_panel/side_panel.html.twig
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
   
     
   
   Figma design:   
   
   
   
   | 
…tService and simplifying markNotificationAsReadAction
| 
 https://github.com/user-attachments/assets/9024b652-873e-4a15-b6a7-61dd955d19cb 
 go.to.content.mov | 
        
          
                src/bundle/Resources/public/js/scripts/admin.notifications.filters.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/views/themes/admin/account/notifications/list_item_all.html.twig
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/views/themes/admin/account/notifications/list_item_all.html.twig
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/bundle/Resources/views/themes/admin/ui/component/side_panel/side_panel.html.twig
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved 🥳
Regression: ibexa/commerce#1486




Related PRs:
inexpression for multi-status support core#627Description:
For QA:
Documentation: