Skip to content

IBX-9776: Fix eslint errors on main branches #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

IBX-9776: Fix eslint errors on main branches #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bundle/Resources/public/js/scripts/admin.format.date.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,17 @@
};

const formatEscapedString = function (icuStr) {
// eslint-disable-next-line quotes
// eslint-disable-next-line @stylistic/quotes
if (icuStr === "''") {
return "[']"; // eslint-disable-line quotes
return "[']"; // eslint-disable-line @stylistic/quotes
}

return icuStr.replace(/'(.*)'/g, '[$1]').replace(/''/g, "'"); // eslint-disable-line quotes
return icuStr.replace(/'(.*)'/g, '[$1]').replace(/''/g, "'"); // eslint-disable-line @stylistic/quotes
};

moment.fn.formatICU = function (format) {
const form = format.replace(formatICUEx, (icuStr) => {
// eslint-disable-next-line quotes
// eslint-disable-next-line @stylistic/quotes
if (icuStr[0] === "'") {
return formatEscapedString(icuStr);
}
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/scripts/core/tag.view.select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as middleEllipsisHelper from '@ibexa-admin-ui/src/bundle/Resources/publ
this.container = config.container || config.fieldContainer.querySelector('.ibexa-tag-view-select');

if (!this.container) {
throw new Error("Field Container doesn't exist!"); // eslint-disable-line quotes
throw new Error("Field Container doesn't exist!"); // eslint-disable-line @stylistic/quotes
Copy link
Contributor

@RopRaptor RopRaptor Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considering making a rule for eslint to give just a "warn" for quotes?

Something like:
rules: {
quotes: ["warn", "double"]
},

}

this.listContainer = this.container.querySelector('.ibexa-tag-view-select__selected-list');
Expand Down
1 change: 1 addition & 0 deletions src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

this.showPreviewEventName = 'ibexa-image-asset:show-preview';
}

/**
* Creates a new Image Asset
*
Expand Down
5 changes: 3 additions & 2 deletions src/bundle/ui-dev/src/modules/common/thumbnail/thumbnail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';

import Icon from '../icon/icon';
import ThumbnailProps from './thumbnail.types';

Expand All @@ -10,15 +11,15 @@ const Thumbnail = ({ thumbnailData, iconExtraClasses, contentTypeIconPath }: Thu

return (
<div className="c-thumbnail__icon-wrapper">
<Icon extraClasses="ibexa-icon--small" customPath={contentTypeIconPath} />
<Icon customPath={contentTypeIconPath} extraClasses="ibexa-icon--small" />
</div>
);
};

if (thumbnailData.mimeType === 'image/svg+xml') {
return (
<div className="c-thumbnail">
<Icon extraClasses={iconExtraClasses} customPath={thumbnailData.resource} />
<Icon customPath={thumbnailData.resource} extraClasses={iconExtraClasses} />
</div>
);
}
Expand Down
Loading