IBX-8471: Upgraded codebase to Symfony 7

composer.json

@@ -23,7 +23,7 @@
     "require": {
         "php": " >=8.3",
         "ext-json": "*",
-        "babdev/pagerfanta-bundle": "^3.8",
+        "babdev/pagerfanta-bundle": "^4.5",
         "ibexa/content-forms": "~5.0.x-dev",
         "ibexa/core": "~5.0.x-dev",
         "ibexa/design-engine": "~5.0.x-dev",
@@ -34,41 +34,41 @@
         "jms/translation-bundle": "^2.4",
         "knplabs/knp-menu-bundle": "^3.0",
         "mck89/peast": "^1.9",
-        "symfony/asset": "^6.4",
-        "symfony/config": "^6.4",
-        "symfony/console": "^6.4",
-        "symfony/dependency-injection": "^6.4",
+        "symfony/asset": "^7.2",
+        "symfony/config": "^7.2",
+        "symfony/console": "^7.2",
+        "symfony/dependency-injection": "^7.2",
         "symfony/deprecation-contracts": "^2.5 || ^3.0",
-        "symfony/event-dispatcher": "^6.4",
-        "symfony/filesystem": "^6.4",
-        "symfony/form": "^6.4",
-        "symfony/http-foundation": "^6.4",
-        "symfony/http-kernel": "^6.4",
-        "symfony/options-resolver": "^6.4",
-        "symfony/routing": "^6.4",
-        "symfony/security-core": "^6.4",
-        "symfony/security-http": "^6.4",
-        "symfony/translation": "^6.4",
-        "symfony/validator": "^6.4",
-        "symfony/webpack-encore-bundle": "^1.17",
-        "symfony/yaml": "^6.4",
+        "symfony/event-dispatcher": "^7.2",
+        "symfony/filesystem": "^7.2",
+        "symfony/form": "^7.2",
+        "symfony/http-foundation": "^7.2",
+        "symfony/http-kernel": "^7.2",
+        "symfony/options-resolver": "^7.2",
+        "symfony/routing": "^7.2",
+        "symfony/security-core": "^7.2",
+        "symfony/security-http": "^7.2",
+        "symfony/translation": "^7.2",
+        "symfony/validator": "^7.2",
+        "symfony/webpack-encore-bundle": "^2.2",
+        "symfony/yaml": "^7.2",
         "twig/intl-extra": "^3.0",
         "twig/string-extra": "^3.0",
         "twig/twig": "^3.0",
         "willdurand/js-translation-bundle": "^6.1"
     },
     "require-dev": {
         "ext-zip": "*",
-        "dama/doctrine-test-bundle": "^v6.7",
+        "dama/doctrine-test-bundle": "^8.2",
         "ibexa/behat": "~5.0.x-dev",
         "ibexa/code-style": "~2.0.0",
         "ibexa/doctrine-schema": "~5.0.x-dev",
         "ibexa/http-cache": "~5.0.x-dev",
         "ibexa/notifications": "~5.0.x-dev",
+        "ibexa/rector": "~5.0.x-dev",
         "ibexa/test-core": "~5.0.x-dev",
         "ibexa/test-rest": "~5.0.x-dev",
-        "ibexa/rector": "~5.0.x-dev",
-        "matthiasnoback/symfony-dependency-injection-test": "^4.0",
+        "matthiasnoback/symfony-dependency-injection-test": "^5.0",
         "phpstan/phpstan": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0",
         "phpstan/phpstan-symfony": "^2.0",

phpstan-baseline.neon

@@ -4585,8 +4585,8 @@ parameters:
 			path: src/lib/Form/DataTransformer/DateIntervalTransformer.php
 
 		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\DateTimePickerTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
+			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\DateTimePickerTransformer\:\:reverseTransform\(\) should return DateTimeInterface\|null but returns DateTime\|false\.$#'
+			identifier: return.type
 			count: 1
 			path: src/lib/Form/DataTransformer/DateTimePickerTransformer.php
 
@@ -4614,24 +4614,12 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/FieldType/AbstractBinaryBaseTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\AuthorValueTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/AuthorValueTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\BinaryFileValueTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
 			count: 1
 			path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php
 
-		-
-			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\BinaryFileValueTransformer\:\:reverseTransform\(\) has parameter \$value with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php
-
 		-
 			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\BinaryFileValueTransformer\:\:transform\(\) return type has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -4644,12 +4632,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php
 
-		-
-			message: '#^Strict comparison using \=\=\= between null and Ibexa\\Core\\FieldType\\BinaryFile\\Value will always evaluate to false\.$#'
-			identifier: identical.alwaysFalse
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\DateTimeValueTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
@@ -4758,36 +4740,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/FieldType/KeywordValueTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\MediaValueTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
-
-		-
-			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\MediaValueTransformer\:\:reverseTransform\(\) has parameter \$value with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
-
-		-
-			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\MediaValueTransformer\:\:transform\(\) return type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
-
-		-
-			message: '#^Parameter \#1 \.\.\.\$arrays of function array_merge expects array, array\|null given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
-
-		-
-			message: '#^Strict comparison using \=\=\= between null and Ibexa\\Core\\FieldType\\Media\\Value will always evaluate to false\.$#'
-			identifier: identical.alwaysFalse
-			count: 1
-			path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\FieldType\\RelationListValueTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
@@ -4848,12 +4800,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/LocationsTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\MultilingualSelectionTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/MultilingualSelectionTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\ObjectStateGroupTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
@@ -4884,24 +4830,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/PolicyTransformer.php
 
-		-
-			message: '#^Access to protected property Ibexa\\Contracts\\Core\\Repository\\Values\\User\\RoleAssignment\:\:\$id\.$#'
-			identifier: property.protected
-			count: 1
-			path: src/lib/Form/DataTransformer/RoleAssignmentTransformer.php
-
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\RoleAssignmentTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/RoleAssignmentTransformer.php
-
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\RoleTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/RoleTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\SectionTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
@@ -4920,18 +4848,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/SectionsTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\TranslatablePropertyTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/TranslatablePropertyTransformer.php
-
-		-
-			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\TranslatablePropertyTransformer\:\:__construct\(\) has parameter \$languageCode with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: src/lib/Form/DataTransformer/TranslatablePropertyTransformer.php
-
 		-
 			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\TrashItemTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
 			identifier: missingType.generics
@@ -4968,18 +4884,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/UDWBasedValueModelTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\UDWBasedValueViewTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/UDWBasedValueViewTransformer.php
-
-		-
-			message: '#^Parameter \#1 \$callback of function array_map expects \(callable\(string\)\: mixed\)\|null, array\{Ibexa\\Contracts\\Core\\Repository\\LocationService, ''loadLocation''\} given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/lib/Form/DataTransformer/UDWBasedValueViewTransformer.php
-
 		-
 			message: '#^Call to function is_string\(\) with non\-falsy\-string will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
@@ -5040,24 +4944,6 @@ parameters:
 			count: 1
 			path: src/lib/Form/DataTransformer/UserGroupCollectionTransformer.php
 
-		-
-			message: '#^Class Ibexa\\AdminUi\\Form\\DataTransformer\\UserTransformer implements generic interface Symfony\\Component\\Form\\DataTransformerInterface but does not specify its types\: T, R$#'
-			identifier: missingType.generics
-			count: 1
-			path: src/lib/Form/DataTransformer/UserTransformer.php
-
-		-
-			message: '#^Instanceof between Ibexa\\Contracts\\Core\\Repository\\Values\\User\\User and Ibexa\\Contracts\\Core\\Repository\\Values\\User\\User will always evaluate to true\.$#'
-			identifier: instanceof.alwaysTrue
-			count: 1
-			path: src/lib/Form/DataTransformer/UserTransformer.php
-
-		-
-			message: '#^Method Ibexa\\AdminUi\\Form\\DataTransformer\\UserTransformer\:\:transform\(\) has Symfony\\Component\\Form\\Exception\\TransformationFailedException in PHPDoc @throws tag but it''s not thrown\.$#'
-			identifier: throws.unusedType
-			count: 1
-			path: src/lib/Form/DataTransformer/UserTransformer.php
-
 		-
 			message: '#^Call to function is_array\(\) with array will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
@@ -9456,12 +9342,6 @@ parameters:
 			count: 1
 			path: src/lib/Validator/Constraints/LocationIsNotRootValidator.php
 
-		-
-			message: '#^Property Ibexa\\AdminUi\\Validator\\Constraints\\LocationIsNotSubLocation\:\:\$message has no type specified\.$#'
-			identifier: missingType.property
-			count: 1
-			path: src/lib/Validator/Constraints/LocationIsNotSubLocation.php
-
 		-
 			message: '#^Property Ibexa\\AdminUi\\Validator\\Constraints\\LocationIsWithinCopySubtreeLimit\:\:\$message has no type specified\.$#'
 			identifier: missingType.property
@@ -9774,54 +9654,6 @@ parameters:
 			count: 1
 			path: tests/bundle/Templating/Twig/LimitationMock.php
 
-		-
-			message: '#^Instantiated class PHPUnit_Framework_Constraint_Exception not found\.$#'
-			identifier: class.notFound
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$condition with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$deprecation with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$exception with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$file with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$message with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$outputs with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:doIntegrationTest\(\) has parameter \$templates with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Bundle\\AdminUi\\Templating\\Twig\\LimitationValueRenderingExtensionTest\:\:getLimitation\(\) has parameter \$identifier with no type specified\.$#'
 			identifier: missingType.parameter
@@ -9834,12 +9666,6 @@ parameters:
 			count: 1
 			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
 
-		-
-			message: '#^Parameter \#1 \$name of method Twig\\Loader\\LoaderInterface\:\:getSourceContext\(\) expects string, int\|string given\.$#'
-			identifier: argument.type
-			count: 1
-			path: tests/bundle/Templating/Twig/LimitationValueRenderingExtensionTest.php
-
 		-
 			message: '#^Parameter \#1 \$valueMapperRegistry of class Ibexa\\AdminUi\\Limitation\\Templating\\LimitationBlockRenderer constructor expects Ibexa\\AdminUi\\Limitation\\LimitationValueMapperRegistryInterface, PHPUnit\\Framework\\MockObject\\MockObject given\.$#'
 			identifier: argument.type

src/lib/Form/DataTransformer/ContentTypeTransformer.php

@@ -32,7 +32,7 @@ public function __construct(ContentTypeService $contentTypeService)
      *
      * @return string|null
      */
-    public function transform($value)
+    public function transform(mixed $value): ?string
     {
         return null !== $value
             ? $value->identifier
@@ -46,7 +46,7 @@ public function transform($value)
      *
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
      */
-    public function reverseTransform($value)
+    public function reverseTransform(mixed $value): ?ContentType
     {
         return null !== $value && !empty($value)
             ? $this->contentTypeService->loadContentTypeByIdentifier($value)

src/lib/Form/DataTransformer/DateIntervalTransformer.php

@@ -23,7 +23,7 @@ class DateIntervalTransformer implements DataTransformerInterface
      *
      * @throws \Symfony\Component\Form\Exception\TransformationFailedException
      */
-    public function transform($value)
+    public function transform(mixed $value): ?array
     {
         return null;
     }
@@ -38,7 +38,7 @@ public function transform($value)
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
      */
-    public function reverseTransform($value)
+    public function reverseTransform(mixed $value): ?array
     {
         if (null === $value || !is_array($value) || empty($value['date_interval'])) {
             return [];