IBX-9636: Pagination arrows not displayed correctly #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tischsoic
approved these changes
Feb 26, 2025
albozek
approved these changes
Feb 26, 2025
mikadamczyk
approved these changes
Feb 26, 2025
ciastektk
approved these changes
Feb 26, 2025
konradoboza
approved these changes
Feb 26, 2025
adamwojs
approved these changes
Feb 26, 2025
dew326
approved these changes
Feb 26, 2025
This was referenced Feb 26, 2025
micszo
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The problem is the lack of
.prevand.nextcss classes that we use to style the buttons.Ibexa DXP v5.0 uses
"pagerfant/pagerfant": "^3.6.2"while in v4.6"pagerfant/pagerfant": "^2.7"the getDefaultOptions method returning defaults paramteres has changed between versions.Pagerfanta 3.x:
css_prev_classandcss_next_classreturn empty stringhttps://github.com/BabDev/Pagerfanta/blob/3.x/lib/Core/View/Template/TwitterBootstrapTemplate.php#L21-L22
Pagerfanta 2.x:
css_prev_classreturn css classprevcss_next_classreturn css classnexthttps://github.com/BabDev/Pagerfanta/blob/2.x/lib/Core/View/Template/TwitterBootstrapTemplate.php#L16-L17
For QA:
Documentation: