Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8602: Always load root location using sudo in the ContentTreeController #1298

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Jul 24, 2024

🎫 Issue IBX-8602

Description:

The issue stems from the fact that we are loading the location of ID = 1. If a user has some limitations on locations or subtrees, even if he selected all of them he won't be able to load the root location of ID = 1. Another limitation is that we cannot select the root location in limitations.

The following PR proposes to always load the root location using sudo and the rest of them using a standard call with policies validation.

If we won't go with this solution we have probably one option and that is to load multiple tree roots in the frontend simultaneously, it probably requires a lot of work.

@barw4 barw4 self-assigned this Jul 24, 2024
@barw4 barw4 added Bug Something isn't working Work in progress labels Jul 24, 2024
@barw4 barw4 changed the title IBX-8645: Always load root location using sudo in the ContentTreeController IBX-8645: Always load root location using sudo in the ContentTreeController Jul 24, 2024
@barw4 barw4 marked this pull request as ready for review July 24, 2024 22:22
@barw4 barw4 requested a review from a team July 25, 2024 07:49
@barw4 barw4 changed the title IBX-8645: Always load root location using sudo in the ContentTreeController IBX-8602: Always load root location using sudo in the ContentTreeController Jul 25, 2024
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure about loading root node without permissions. Specifically, I think it is also possible to declare root locations for site accesses.

I am almost certain that's not gonna hold due to security.

Copy link

sonarqubecloud bot commented Aug 1, 2024

@barw4 barw4 requested review from Steveb-p and a team August 2, 2024 07:49
@konradoboza konradoboza requested a review from a team August 2, 2024 07:52
@barw4 barw4 requested a review from konradoboza August 2, 2024 08:13
@Steveb-p Steveb-p requested a review from a team August 2, 2024 08:15
@konradoboza konradoboza requested a review from a team August 2, 2024 08:17
@tomaszszopinski tomaszszopinski self-assigned this Aug 6, 2024
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@Nattfarinn Nattfarinn merged commit 0005da5 into 4.6 Aug 6, 2024
25 checks passed
@Nattfarinn Nattfarinn deleted the ibx-8645-sudo-root-location-ContentTreeController branch August 6, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants