-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8602: Always load root location using sudo
in the ContentTreeController
#1298
IBX-8602: Always load root location using sudo
in the ContentTreeController
#1298
Conversation
ContentTreeController
sudo
in the ContentTreeController
sudo
in the ContentTreeController
sudo
in the ContentTreeController
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure about loading root node without permissions. Specifically, I think it is also possible to declare root locations for site accesses.
I am almost certain that's not gonna hold due to security.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.6 commerce.
Description:
The issue stems from the fact that we are loading the location of ID =
1
. If a user has some limitations on locations or subtrees, even if he selected all of them he won't be able to load the root location of ID =1
. Another limitation is that we cannot select the root location in limitations.The following PR proposes to always load the root location using
sudo
and the rest of them using a standard call with policies validation.If we won't go with this solution we have probably one option and that is to load multiple tree roots in the frontend simultaneously, it probably requires a lot of work.