IBX-8142: removed depreacated code #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-8142
branch
4 times, most recently
from
36f10ca to
de22de9
Compare
OstafinL
requested changes
Apr 24, 2024
| const deleteBtn = container.querySelector(SELECTOR_RESET_STARTING_LOCATION_BTN); | ||
|
|
||
| ibexa.helpers.ellipsis.middle.parseAll(); | ||
| ibexa.helpers.ellipsis.middle.parse(); |
There was a problem hiding this comment.
maybe we could import this function from helper instead use global object window.ibexa?
dew326
approved these changes
Apr 24, 2024
Gengar-i
approved these changes
Apr 24, 2024
tischsoic
approved these changes
Apr 25, 2024
OstafinL
approved these changes
May 6, 2024
|
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Two browser tests are failing, as they try to download and use packages from dependencies.json that are not available in their product edition.
For QA:
Documentation: