Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bilibili dash&4K #732

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Bilibili dash&4K #732

merged 7 commits into from
Jul 8, 2020

Conversation

Half9000
Copy link
Contributor

@Half9000 Half9000 commented Jul 4, 2020

The old interface is not valid for getting 4K format(#670) or some URL(#716).
Some users also reported that using DASH API to download might be faster. (#684 )
Change the API to the latest DASH API;
Update the extract method for bilibil;

4K Test
annie -c cookies.txt -i https://www.bilibili.com/video/av412909688

 Site:      哔哩哔哩 bilibili.com
 Title:     【何同学4K】3299真香？iPhone SE使用体验
 Type:      video
 Streams:   # All available quality
     [120]  -------------------
     Quality:         超清 4K
     Size:            275.73 MiB (289127402 Bytes)
     # download with: annie -f 120 ...

     [112]  -------------------
     Quality:         高清 1080P+
     Size:            208.00 MiB (218105640 Bytes)
     # download with: annie -f 112 ...

     [80]  -------------------
     Quality:         高清 1080P
     Size:            29.26 MiB (30676328 Bytes)
     # download with: annie -f 80 ...

     [64]  -------------------
     Quality:         高清 720P
     Size:            21.10 MiB (22125737 Bytes)
     # download with: annie -f 64 ...

     [32]  -------------------
     Quality:         清晰 480P
     Size:            12.11 MiB (12695063 Bytes)
     # download with: annie -f 32 ...

     [16]  -------------------
     Quality:         流畅 360P
     Size:            11.95 MiB (12527097 Bytes)
     # download with: annie -f 16 ...

Half9000 added 2 commits July 5, 2020 00:07
@Half9000
fix(bilibili): Update bangumi API
dbdb232 
Update bangumi API (typo);
Removed seasonType param(unparam);
Removed unreached codes;
@Half9000
extractors/bilibili: Update tests
174b44a
iawia002
iawia002 reviewed Jul 7, 2020
View reviewed changes
Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, basically LGTM, just a few comments

extractors/bilibili/bilibili.go Outdated Show resolved Hide resolved
extractors/bilibili/bilibili.go Outdated Show resolved Hide resolved
@iawia002 iawia002 merged commit c48882c into iawia002:master Jul 8, 2020
@mengmo mengmo mentioned this pull request Jul 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iawia002 iawia002 iawia002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half9000 @iawia002