-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap structure for a widget examples repo #13
Conversation
Example CI run in the fork: jtpio#1 |
Seeing some Maybe we can keep |
Listing a couple of items to iterate on in follow-up PRs:
|
cc @ianhi if you want to have a look. This PR is mostly about adding the tooling and the structure, more than actually working on the examples themselves. Maybe there could be a couple more iterations before renaming the repo to |
Hi @jtpio thanks so much for starting on this! I've been busy at the start of this week but will look at this tomorrow (today now?) evening. |
I had been playing a bit fast and loose with some of the formatting which prettier then mangled. So I updated that and removed some outdated portions of the readme. |
@@ -9,14 +8,12 @@ Exploring how to give access of a widget's typescript model to a different widge | |||
|
|||
**Important questions:** | |||
|
|||
Q: Is this good practice? - A: I have no idea | |||
Q: Is this good practice? - A: I have no idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio do you know the answer to this?
|
||
## Structure | ||
|
||
This example was bootstrapped from the [Jupyter TypeScript Cookiecutter](https://github.com/jupyter-widgets/widget-ts-cookiecutter) and follows the same structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example was bootstrapped from the [Jupyter TypeScript Cookiecutter](https://github.com/jupyter-widgets/widget-ts-cookiecutter) and follows the same structure. | |
This example was bootstrapped from the [Jupyter Widget TypeScript Cookiecutter](https://github.com/jupyter-widgets/widget-ts-cookiecutter) and follows the same structure. |
Is that a more correct phrasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. Thanks so much for this. I have some follow up questions about how to best improve this but they can go into new issues.
First step towards a "Widget Examples" repository for
ipywidgets
: jupyter-widgets/ipywidgets#3136Heavily inspired by the JupyterLab Extension Examples: https://github.com/jupyterlab/extension-examples
The idea is to set up the basic structure for multiple custom widget examples in the same repo, so that we have the tools and CI in place to iterate and easily add new examples.
TODO
hello-world
example bootstrapped from the TS cookiecutter: https://github.com/jupyter-widgets/widget-ts-cookiecutter