feat: Introduce name property for SNS channel binding object#7
Merged
iancooper merged 2 commits intoiancooper:aws-bindingsfrom Feb 9, 2022
Merged
feat: Introduce name property for SNS channel binding object#7iancooper merged 2 commits intoiancooper:aws-bindingsfrom
iancooper merged 2 commits intoiancooper:aws-bindingsfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
ssemyonov
changed the title
Owner
|
Merged, I need to merge upstream as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this change is to provide additional flexibility when describing infrastructure as a code.
Using channel names to create actual AWS resources is not flexible enough as different environments might have different topic names to avoid conflicts if used in the same AWS account. Or more generally, the channel names can be described in domain-friendly terms which would be hard to match with AWS state, especially when onboarding existing infrastructure with unclear topic names (which were shortened for AWS length limit reasons for example).